[PATCH] new fix: radeon backlight shutoff flashes momentarily

[PATCH] new fix: radeon backlight shutoff flashes momentarily

[Robert T. Drury]

This patch should replace the previous
fix-radeon-backlight-shutoff-flashes-momentarily.patch added to -mm tree

This replacement patch removes only the & ~LVDS_BL_MOD_EN on shutoff 
and applies only to machine powerbook5,3 && CHIP_FAMILY_RV350. 

Signed-off-by: Robert Drury <rtdrury@earthlink.net>

--- linux-2.6.23.9/drivers/video/aty/radeon_backlight.c.orig	2009-03-22 19:04:22.000000000 -0700
+++ linux-2.6.23.9/drivers/video/aty/radeon_backlight.c	2009-03-22 19:19:09.000000000 -0700
@@ -101,7 +101,10 @@ static int radeon_bl_update_status(struc
 		tmpPixclksCntl = INPLL(PIXCLKS_CNTL);
 		if (rinfo->is_mobility || rinfo->is_IGP)
 			OUTPLLP(PIXCLKS_CNTL, 0, ~PIXCLK_LVDS_ALWAYS_ONb);
-		lvds_gen_cntl &= ~(LVDS_BL_MOD_LEVEL_MASK | LVDS_BL_MOD_EN);
+		lvds_gen_cntl &= ~(LVDS_BL_MOD_LEVEL_MASK);
+		if(rinfo->family != CHIP_FAMILY_RV350 
+			|| !machine_is_compatible("PowerBook5,3"))
+				lvds_gen_cntl &= ~LVDS_BL_MOD_EN;
 		lvds_gen_cntl |= (radeon_bl_get_level_brightness(pdata, 0) <<
 				  LVDS_BL_MOD_LEVEL_SHIFT);
 		lvds_gen_cntl |= LVDS_DISPLAY_DIS;


------------------------------------------------------------------------------
Apps built with the Adobe(R) Flex(R) framework and Flex Builder(TM) are
powering Web 2.0 with engaging, cross-platform capabilities. Quickly and
easily build your RIAs with Flex Builder, the Eclipse(TM)based development
software that enables intelligent coding and step-through debugging.
Download the free 60 day trial. http://p.sf.net/sfu/www-adobe-com

Re: [PATCH] new fix: radeon backlight shutoff flashes momentarily

[Michel Dänzer]

On Sun, 2009-03-22 at 22:10 -0700, Robert T. Drury wrote:
> This patch should replace the previous
> fix-radeon-backlight-shutoff-flashes-momentarily.patch added to -mm tree
> 
> This replacement patch removes only the & ~LVDS_BL_MOD_EN on shutoff 
> and applies only to machine powerbook5,3 && CHIP_FAMILY_RV350. 

I think I'm also seeing the flash on a PowerBook5,8. Is there reason to
believe any model with an RV350 isn't affected?


-- 
Earthling Michel Dänzer           |                http://www.vmware.com
Libre software enthusiast         |          Debian, X and DRI developer

------------------------------------------------------------------------------
Apps built with the Adobe(R) Flex(R) framework and Flex Builder(TM) are
powering Web 2.0 with engaging, cross-platform capabilities. Quickly and
easily build your RIAs with Flex Builder, the Eclipse(TM)based development
software that enables intelligent coding and step-through debugging.
Download the free 60 day trial. http://p.sf.net/sfu/www-adobe-com
_______________________________________________
Linux-fbdev-devel mailing list
Linux-fbdev-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-fbdev-devel

Re: [PATCH] new fix: radeon backlight shutoff flashes momentarily

[Andrew Morton]

On Sun, 22 Mar 2009 22:10:10 -0700
"Robert T. Drury" <rtdrury@earthlink.net> wrote:

> This patch should replace the previous
> fix-radeon-backlight-shutoff-flashes-momentarily.patch added to -mm tree
> 
> This replacement patch removes only the & ~LVDS_BL_MOD_EN on shutoff 
> and applies only to machine powerbook5,3 && CHIP_FAMILY_RV350. 

The above text is not a suitable changelog for this patch.

> Signed-off-by: Robert Drury <rtdrury@earthlink.net>
> 
> --- linux-2.6.23.9/drivers/video/aty/radeon_backlight.c.orig	2009-03-22 19:04:22.000000000 -0700
> +++ linux-2.6.23.9/drivers/video/aty/radeon_backlight.c	2009-03-22 19:19:09.000000000 -0700
> @@ -101,7 +101,10 @@ static int radeon_bl_update_status(struc
>  		tmpPixclksCntl = INPLL(PIXCLKS_CNTL);
>  		if (rinfo->is_mobility || rinfo->is_IGP)
>  			OUTPLLP(PIXCLKS_CNTL, 0, ~PIXCLK_LVDS_ALWAYS_ONb);
> -		lvds_gen_cntl &= ~(LVDS_BL_MOD_LEVEL_MASK | LVDS_BL_MOD_EN);
> +		lvds_gen_cntl &= ~(LVDS_BL_MOD_LEVEL_MASK);
> +		if(rinfo->family != CHIP_FAMILY_RV350 
> +			|| !machine_is_compatible("PowerBook5,3"))
> +				lvds_gen_cntl &= ~LVDS_BL_MOD_EN;
>  		lvds_gen_cntl |= (radeon_bl_get_level_brightness(pdata, 0) <<
>  				  LVDS_BL_MOD_LEVEL_SHIFT);
>  		lvds_gen_cntl |= LVDS_DISPLAY_DIS;

The text which I have for
fix-radeon-backlight-shutoff-flashes-momentarily.patch is:

  Addresses http://bugzilla.kernel.org/show_bug.cgi?id=12845

  Aluminum powerbook G4 with radeon.

  The backlight momentarily flashes brightly when turning off.  If the
  backlight is originally dim, the flash is more noticeable.  This momentary
  flash is stressful on the power circuit.

  The first OUTREG to LVDS_GEN_CNTL causes the flashing problem.  To fix,
  remove the first manipulation of lvds_gen_cntl above it.

  Second manipulation of lvds_gen_cntl does nothing (level always zero). 
  The first manipulation was needed so the display would not be garbled
  after turning the backlight back on, but at least on my powerbook, the
  garbling seems to go away when the udelay is 1000.


but as that is no longer appropriate to the new patch, there's nothing
I can do.

I'll drop the old patch.  Please resend.


------------------------------------------------------------------------------