From: "Robert T. Drury" <rtdrury@earthlink.net>
To: linux-fbdev-devel@lists.sourceforge.net,
benh@kernel.crashing.org, akpm@linux-foundation.org
Subject: [PATCH] resend: radeon backlight shutoff flashes momentarily
Date: Wed, 01 Apr 2009 02:27:54 -0700 [thread overview]
Message-ID: <49D3339A.8070603@earthlink.net> (raw)
Addresses http://bugzilla.kernel.org/show_bug.cgi?id=12845
Aluminum Powerbook G4 with Radeon 9600:
The backlight momentarily flashes brightly when turning off. If the
backlight is originally dim, the flash is more noticeable. This momentary
flash is stressful on the power circuit.
This patch removes the & ~LVDS_BL_MOD_EN above the first OUTREG to
LVDS_GEN_CNTL to eliminate the flash on shutoff, only for powerbook5,3
and CHIP_FAMILY_RV350.
Signed-off-by: Robert Drury <rtdrury@earthlink.net>
--- linux-2.6.23.9/drivers/video/aty/radeon_backlight.c.orig 2009-03-22 19:04:22.000000000 -0700
+++ linux-2.6.23.9/drivers/video/aty/radeon_backlight.c 2009-03-22 19:19:09.000000000 -0700
@@ -101,7 +101,10 @@ static int radeon_bl_update_status(struc
tmpPixclksCntl = INPLL(PIXCLKS_CNTL);
if (rinfo->is_mobility || rinfo->is_IGP)
OUTPLLP(PIXCLKS_CNTL, 0, ~PIXCLK_LVDS_ALWAYS_ONb);
- lvds_gen_cntl &= ~(LVDS_BL_MOD_LEVEL_MASK | LVDS_BL_MOD_EN);
+ lvds_gen_cntl &= ~(LVDS_BL_MOD_LEVEL_MASK);
+ if(rinfo->family != CHIP_FAMILY_RV350
+ || !machine_is_compatible("PowerBook5,3"))
+ lvds_gen_cntl &= ~LVDS_BL_MOD_EN;
lvds_gen_cntl |= (radeon_bl_get_level_brightness(pdata, 0) <<
LVDS_BL_MOD_LEVEL_SHIFT);
lvds_gen_cntl |= LVDS_DISPLAY_DIS;
------------------------------------------------------------------------------
next reply other threads:[~2009-04-01 9:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-01 9:27 Robert T. Drury [this message]
2009-04-01 11:21 ` [PATCH] resend: radeon backlight shutoff flashes momentarily Michel Dänzer
2009-04-06 14:41 ` Michel Dänzer
2009-04-10 8:45 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49D3339A.8070603@earthlink.net \
--to=rtdrury@earthlink.net \
--cc=akpm@linux-foundation.org \
--cc=benh@kernel.crashing.org \
--cc=linux-fbdev-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).