linux-fbdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Farhan Ali <alifm@linux.vnet.ibm.com>
To: linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org,
	linux-fbdev@vger.kernel.org
Cc: geert@linux-m68k.org, borntraeger@de.ibm.com,
	stefan.kristiansson@saunalahti.fi, tomi.valkeinen@ti.com,
	schwidefsky@de.ibm.com, alifm@linux.vnet.ibm.com
Subject: [PATCH v2 1/3] Kconfig : Remove HAS_IOMEM dependency for Graphics support
Date: Thu, 01 Feb 2018 18:41:28 +0000	[thread overview]
Message-ID: <49ef903a791cbca658194c68932eb90450027774.1517508744.git.alifm@linux.vnet.ibm.com> (raw)
In-Reply-To: <cover.1517508744.git.alifm@linux.vnet.ibm.com>

The 'commit e25df1205f37 ("[S390] Kconfig: menus with depends on HAS_IOMEM.")'
added the HAS_IOMEM dependecy for "Graphics support". This disabled the
"Graphics support" menu for S390. But if we enable VT layer for S390,
we would also need to enable the dummy console. So let's remove the
HAS_IOMEM dependency.

Move this dependency to Opencores framebuffer driver which would fail to build
with CONFIG_HAS_IOMEM disabled:

ERROR: "devm_ioremap_resource" [drivers/video/fbdev/ocfb.ko] undefined!

Signed-off-by: Farhan Ali <alifm@linux.vnet.ibm.com>
Tested-by: Dong Jia Shi <bjsdjshi@linux.vnet.ibm.com>
---
 drivers/video/Kconfig       | 1 -
 drivers/video/fbdev/Kconfig | 2 +-
 2 files changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig
index 3c20af9..41e7ba9 100644
--- a/drivers/video/Kconfig
+++ b/drivers/video/Kconfig
@@ -3,7 +3,6 @@
 #
 
 menu "Graphics support"
-	depends on HAS_IOMEM
 
 config HAVE_FB_ATMEL
 	bool
diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig
index 2f615b7..ec9c9ce 100644
--- a/drivers/video/fbdev/Kconfig
+++ b/drivers/video/fbdev/Kconfig
@@ -966,7 +966,7 @@ config FB_PVR2
 
 config FB_OPENCORES
 	tristate "OpenCores VGA/LCD core 2.0 framebuffer support"
-	depends on FB && HAS_DMA
+	depends on FB && HAS_DMA && HAS_IOMEM
 	select FB_CFB_FILLRECT
 	select FB_CFB_COPYAREA
 	select FB_CFB_IMAGEBLIT
-- 
2.7.4


  reply	other threads:[~2018-02-01 18:41 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-01 18:41 [PATCH v2 0/3]Enable CONFIG_VT support for S390 Farhan Ali
2018-02-01 18:41 ` Farhan Ali [this message]
2018-02-02  7:59   ` [PATCH v2 1/3] Kconfig : Remove HAS_IOMEM dependency for Graphics support Christian Borntraeger
2018-02-08 13:11     ` Bartlomiej Zolnierkiewicz
2018-02-08 15:28       ` Farhan Ali
2018-02-08 15:30       ` Christian Borntraeger
2018-02-14  8:12       ` Christian Borntraeger
2018-02-15  9:40       ` Christian Borntraeger
2018-02-15 11:02         ` Christian Borntraeger
2018-02-15 11:14         ` [PATCH] s390/console: enable dummy console for vt Christian Borntraeger
2018-02-15 11:26           ` Geert Uytterhoeven
2018-02-15 11:56             ` Christian Borntraeger
2018-02-15 11:57             ` Thomas Huth
2018-02-15 12:02               ` Christian Borntraeger
2018-02-19 13:35                 ` Farhan Ali
2018-02-19 13:37                   ` Christian Borntraeger
2018-02-19 14:01                     ` Farhan Ali
2018-02-06 12:36   ` [PATCH v2 1/3] Kconfig : Remove HAS_IOMEM dependency for Graphics support Thomas Huth
2018-02-01 18:41 ` [PATCH v2 2/3] s390/char : Rename EBCDIC keymap variables Farhan Ali
2018-02-01 18:41 ` [PATCH v2 3/3] s390/setup : enable display support for KVM guest Farhan Ali

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49ef903a791cbca658194c68932eb90450027774.1517508744.git.alifm@linux.vnet.ibm.com \
    --to=alifm@linux.vnet.ibm.com \
    --cc=borntraeger@de.ibm.com \
    --cc=geert@linux-m68k.org \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=schwidefsky@de.ibm.com \
    --cc=stefan.kristiansson@saunalahti.fi \
    --cc=tomi.valkeinen@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).