From: Roel Kluin <roel.kluin@gmail.com>
To: adaplas@gmail.com
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-fbdev-devel@lists.sourceforge.net
Subject: [PATCH] staging: misplaced parentheses?
Date: Thu, 14 May 2009 14:19:26 +0200 [thread overview]
Message-ID: <4A0C0C4E.6070401@gmail.com> (raw)
The leftmost `+' has a higher precedence than the `?' so this returns
(vres * hres * (1 << color_mode) + (VMODE && CMODE) ? 0x10 : 0x20) + 0x1000
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
The original code looks odd, but I am not entirely certain whether my patch is
correct. So please review.
diff --git a/drivers/video/platinumfb.c b/drivers/video/platinumfb.c
index 03b3670..a88f4b6 100644
--- a/drivers/video/platinumfb.c
+++ b/drivers/video/platinumfb.c
@@ -224,7 +224,7 @@ static inline int platinum_vram_reqd(int video_mode, int color_mode)
return vmode_attrs[video_mode-1].vres *
(vmode_attrs[video_mode-1].hres * (1<<color_mode) +
((video_mode == VMODE_832_624_75) &&
- (color_mode > CMODE_8)) ? 0x10 : 0x20) + 0x1000;
+ (color_mode > CMODE_8) ? 0x10 : 0x20)) + 0x1000;
}
#define STORE_D2(a, d) { \
------------------------------------------------------------------------------
The NEW KODAK i700 Series Scanners deliver under ANY circumstances! Your
production scanning environment may not be a perfect world - but thanks to
Kodak, there's a perfect scanner to get the job done! With the NEW KODAK i700
Series Scanner you'll get full speed at 300 dpi even with all image
processing features enabled. http://p.sf.net/sfu/kodak-com
next reply other threads:[~2009-05-14 12:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-14 12:19 Roel Kluin [this message]
2009-05-14 16:38 ` [PATCH] staging: misplaced parentheses? Andrew Morton
2009-05-14 23:24 ` Benjamin Herrenschmidt
2009-05-15 10:51 ` Roel Kluin
2009-05-15 20:43 ` [PATCH] platinumfb: misplaced parenthesis Roel Kluin
2009-05-15 21:24 ` Ville Syrjälä
2009-05-15 22:21 ` Benjamin Herrenschmidt
2009-05-17 11:53 ` Roel Kluin
2009-05-17 17:11 ` Geert Uytterhoeven
2009-05-18 10:23 ` Roel Kluin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A0C0C4E.6070401@gmail.com \
--to=roel.kluin@gmail.com \
--cc=adaplas@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-fbdev-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).