From: Kai Jiang <b18973@freescale.com>
To: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
Cc: linux-fbdev-devel@lists.sourceforge.net
Subject: Re: [linux-fbdev-devel][PATCH]fb_pan_display:add x/yoffset check
Date: Fri, 10 Jul 2009 16:22:17 +0800 [thread overview]
Message-ID: <4A56FA39.1040905@freescale.com> (raw)
In-Reply-To: <4A52C886.4090605@gmx.de>
Florian Tobias Schandinat,
I think your solution is better. It seems much simple in your way:)
Best Regards,
Kai Jiang
>
> I only wanted to highlight, that as far as I can see the same behavior
> you want to archive can be archived by changing the current code to:
>
> fb_pan_display(struct fb_info *info, struct fb_var_screeninfo *var)
> {
> ......
> if (err || !info->fbops->fb_pan_display ||
> var->yoffset > info->var.yres_virtual - yres ||
> var->xoffset > info->var.xres_virtual - info->var.xres)
> return -EINVAL;
> ......
> }
------------------------------------------------------------------------------
Enter the BlackBerry Developer Challenge
This is your chance to win up to $100,000 in prizes! For a limited time,
vendors submitting new applications to BlackBerry App World(TM) will have
the opportunity to enter the BlackBerry Developer Challenge. See full prize
details at: http://p.sf.net/sfu/Challenge
next prev parent reply other threads:[~2009-07-10 8:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-29 3:49 [linux-fbdev-devel][PATCH]fb_pan_display:add x/yoffset check Kai Jiang
2009-06-29 10:39 ` Ville Syrjälä
2009-06-30 3:25 ` Kai Jiang
2009-07-03 15:30 ` Ville Syrjälä
2009-07-03 16:11 ` Florian Tobias Schandinat
2009-07-06 3:00 ` Kai Jiang
2009-07-06 14:12 ` Florian Tobias Schandinat
2009-07-07 2:43 ` Kai Jiang
2009-07-07 4:01 ` Florian Tobias Schandinat
2009-07-10 8:22 ` Kai Jiang [this message]
2009-08-03 18:58 ` [PATCH] fb: fix fb_pan_display range check Florian Tobias Schandinat
2009-07-06 2:54 ` [linux-fbdev-devel][PATCH]fb_pan_display:add x/yoffset check Kai Jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A56FA39.1040905@freescale.com \
--to=b18973@freescale.com \
--cc=FlorianSchandinat@gmx.de \
--cc=linux-fbdev-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).