From: Ryan Mallon <ryan@bluewatersys.com>
To: H Hartley Sweeten <hartleys@visionengravers.com>
Cc: arm kernel <linux-arm-kernel@lists.arm.linux.org.uk>,
linux-fbdev-devel@lists.sourceforge.net,
Daniele Venzano <d.venzano@motronica.com>
Subject: Re: [PATCH 1/2] ep93xx framebuffer driver
Date: Sun, 19 Jul 2009 22:30:59 +1200 [thread overview]
Message-ID: <4A62F5E3.2000208@bluewatersys.com> (raw)
In-Reply-To: <BD79186B4FD85F4B8E60E381CAEE190901AC1FF7@mi8nycmail19.Mi8.com>
H Hartley Sweeten wrote:
> On Thursday, July 16, 2009 8:58 PM, Ryan Mallon wrote:
>> diff --git a/arch/arm/mach-ep93xx/include/mach/ep93xx-regs.h b/arch/arm/mach-ep93xx/include/mach/ep93xx-regs.h
>> index a11ae77..33765fa 100644
>> --- a/arch/arm/mach-ep93xx/include/mach/ep93xx-regs.h
>> +++ b/arch/arm/mach-ep93xx/include/mach/ep93xx-regs.h
>> @@ -70,6 +70,7 @@
>> #define EP93XX_USB_PHYS_BASE (EP93XX_AHB_PHYS_BASE + 0x00020000)
>> #define EP93XX_USB_BASE EP93XX_AHB_IOMEM(0x00020000)
>>
>> +#define EP93XX_RASTER_PHYS_BASE (EP93XX_AHB_PHYS_BASE + 0x00030000)
>> #define EP93XX_RASTER_BASE EP93XX_AHB_IOMEM(0x00030000)
>>
>> #define EP93XX_GRAPHICS_ACCEL_BASE EP93XX_AHB_IOMEM(0x00040000)
>> @@ -206,13 +207,17 @@
>> #define EP93XX_SYSCON_DEVCFG_ADCPD (1<<2)
>> #define EP93XX_SYSCON_DEVCFG_KEYS (1<<1)
>> #define EP93XX_SYSCON_DEVCFG_SHENA (1<<0)
>> +#define EP93XX_SYSCON_VIDCLKDIV EP93XX_SYSCON_REG(0x84)
>> +#define EP93XX_SYSCON_CLKDIV_PSEL (1 << 13)
>> +#define EP93XX_SYSCON_CLKDIV_ESEL (1 << 14)
>> +#define EP93XX_SYSCON_CLKDIV_ENABLE (1 << 15)
>> +#define EP93XX_SYSCON_CLKDIV_PDIV_SHIFT 8
>> #define EP93XX_SYSCON_KEYTCHCLKDIV EP93XX_SYSCON_REG(0x90)
>> #define EP93XX_SYSCON_KEYTCHCLKDIV_TSEN (1<<31)
>> #define EP93XX_SYSCON_KEYTCHCLKDIV_ADIV (1<<16)
>> #define EP93XX_SYSCON_KEYTCHCLKDIV_KEN (1<<15)
>> #define EP93XX_SYSCON_KEYTCHCLKDIV_KDIV (1<<0)
>> #define EP93XX_SYSCON_SWLOCK EP93XX_SYSCON_REG(0xc0)
>
> What tree is this patch based on? The KEYTCHCLKDIV defines are not in Russell's
> devel branch.
I put the patch to fix the keypad #defines in my tree before rebasing
the driver. I think this order is preferred since the keypad defines
patch is needed for the tree to build without errors.
> If (1 << 13) is preferred over (1<<13) we should eventually update this entire file
> so that the defines are consistent.
I prefer the spaces, but I'll change them in the header file so it is
consistent with the rest of the file. We can do a patch later to change
all of the defines in the header file, but I honestly don't think it
matters as long as it is consistent.
~Ryan
-------------------------------------------------------------------
List admin: http://lists.arm.linux.org.uk/mailman/listinfo/linux-arm-kernel
FAQ: http://www.arm.linux.org.uk/mailinglists/faq.php
Etiquette: http://www.arm.linux.org.uk/mailinglists/etiquette.php
next prev parent reply other threads:[~2009-07-19 10:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-17 3:46 [PATCH 1/2] ep93xx framebuffer driver Ryan Mallon
2009-07-17 3:57 ` Ryan Mallon
2009-07-17 17:05 ` H Hartley Sweeten
2009-07-19 10:30 ` Ryan Mallon [this message]
2009-07-17 17:35 ` H Hartley Sweeten
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A62F5E3.2000208@bluewatersys.com \
--to=ryan@bluewatersys.com \
--cc=d.venzano@motronica.com \
--cc=hartleys@visionengravers.com \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=linux-fbdev-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).