linux-fbdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Paulius Zaleckas <paulius.zaleckas@gmail.com>
To: linux-fbdev-devel@lists.sf.net
Cc: sylvain.meyer@worldonline.fr
Subject: [RFC] intelfb + DirectFB + laptop issue
Date: Thu, 29 Oct 2009 14:42:41 +0200	[thread overview]
Message-ID: <4AE98DC1.3070301@gmail.com> (raw)

Hi,

After failing to start DirectFB (tries to get and then set current
resolution) on my asus eeePC I investigated problem and I found out
that it is caused by:

static int intelfb_check_var(struct fb_var_screeninfo *var,
                              struct fb_info *info)
{
...
	if (FIXED_MODE(dinfo) &&
	    (change_var ||
	     var->yres_virtual > dinfo->initial_var.yres_virtual ||
	     var->yres_virtual < dinfo->initial_var.yres ||
	     var->xoffset || var->nonstd)) {
		if (first) {
			ERR_MSG("Changing the video mode is not supported.\n");
			first = 0;
		}
		return -EINVAL;
	}
...

I my situation FIXED_MODE(dinfo) = true, but change_var = false
It still fails since dinfo->initial_var.yres_virtual is initialized
only once as 0, so var->yres_virtual is always bigger value.

Do we need these checks? chnage_var already does size chekings...

fbset -accel [true|false] also fails because of this check.

Please help me to resolve this issue and we should send patch for stable
also.

BR,
Paulius Zaleckas

------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay 
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference

                 reply	other threads:[~2009-10-29 13:20 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4AE98DC1.3070301@gmail.com \
    --to=paulius.zaleckas@gmail.com \
    --cc=linux-fbdev-devel@lists.sf.net \
    --cc=sylvain.meyer@worldonline.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).