[PATCH] atmel_lcdfb: silence compiler warning in device info printk

[PATCH] atmel_lcdfb: silence compiler warning in device info printk

[Hans-Christian Egtvedt]

This patch will tell printk the format for irq_base is a decimal and not an
unsigned long. The irq_base is defined as an int in the struct
atmel_lcdfb_info.

Signed-off-by: Hans-Christian Egtvedt <hans-christian.egtvedt@atmel.com>
---
 drivers/video/atmel_lcdfb.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/video/atmel_lcdfb.c b/drivers/video/atmel_lcdfb.c
index 2830ffd..317afab 100644
--- a/drivers/video/atmel_lcdfb.c
+++ b/drivers/video/atmel_lcdfb.c
@@ -959,7 +959,7 @@ static int __init atmel_lcdfb_probe(struct platform_device *pdev)
 	if (sinfo->atmel_lcdfb_power_control)
 		sinfo->atmel_lcdfb_power_control(1);
 
-	dev_info(dev, "fb%d: Atmel LCDC at 0x%08lx (mapped at %p), irq %lu\n",
+	dev_info(dev, "fb%d: Atmel LCDC at 0x%08lx (mapped at %p), irq %d\n",
 		       info->node, info->fix.mmio_start, sinfo->mmio, sinfo->irq_base);
 
 	return 0;
-- 
1.6.0.4


------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay 
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference

Re: [PATCH] atmel_lcdfb: silence compiler warning in device info printk

[Nicolas Ferre]

Hans-Christian Egtvedt :
> This patch will tell printk the format for irq_base is a decimal and not an
> unsigned long. The irq_base is defined as an int in the struct
> atmel_lcdfb_info.

Hi Hans-Christian,

I guess this patch is already submitted using the name:

    atmel_lcdfb.c: fix printk() type mismatch

It goes his way using "trivial" git tree. It is already in linux-next
(baad1b580a7d08a4062a7f50eab0e06f90ad94d6) and I hope it will be
included in 2.6.32-final.

> Signed-off-by: Hans-Christian Egtvedt <hans-christian.egtvedt@atmel.com>
> ---
>  drivers/video/atmel_lcdfb.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/video/atmel_lcdfb.c b/drivers/video/atmel_lcdfb.c
> index 2830ffd..317afab 100644
> --- a/drivers/video/atmel_lcdfb.c
> +++ b/drivers/video/atmel_lcdfb.c
> @@ -959,7 +959,7 @@ static int __init atmel_lcdfb_probe(struct platform_device *pdev)
>  	if (sinfo->atmel_lcdfb_power_control)
>  		sinfo->atmel_lcdfb_power_control(1);
>  
> -	dev_info(dev, "fb%d: Atmel LCDC at 0x%08lx (mapped at %p), irq %lu\n",
> +	dev_info(dev, "fb%d: Atmel LCDC at 0x%08lx (mapped at %p), irq %d\n",
>  		       info->node, info->fix.mmio_start, sinfo->mmio, sinfo->irq_base);
>  
>  	return 0;

Thanks, Bye,
-- 
Nicolas Ferre


------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay 
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference

Re: [PATCH] atmel_lcdfb: silence compiler warning in device info printk

[Hans-Christian Egtvedt]

On Thu, 29 Oct 2009 14:17:37 +0100
Nicolas Ferre <nicolas.ferre@atmel.com> wrote:

> Hans-Christian Egtvedt :
> > This patch will tell printk the format for irq_base is a decimal and not an
> > unsigned long. The irq_base is defined as an int in the struct
> > atmel_lcdfb_info.
> 
> Hi Hans-Christian,
> 
> I guess this patch is already submitted using the name:
> 
>     atmel_lcdfb.c: fix printk() type mismatch
> 

Okay, thanks, sorry for the noise.

-- 
Best regards,
Hans-Christian Egtvedt

------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay 
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference

Re: [PATCH] atmel_lcdfb: silence compiler warning in device info printk

[Claudio Scordino]

Nicolas Ferre ha scritto:
> Hans-Christian Egtvedt :
>   
>> This patch will tell printk the format for irq_base is a decimal and not an
>> unsigned long. The irq_base is defined as an int in the struct
>> atmel_lcdfb_info.
>>     
>
> Hi Hans-Christian,
>
> I guess this patch is already submitted using the name:
>
>     atmel_lcdfb.c: fix printk() type mismatch
>
> It goes his way using "trivial" git tree. It is already in linux-next
> (baad1b580a7d08a4062a7f50eab0e06f90ad94d6) and I hope it will be
> included in 2.6.32-final.
>   
Hi Hans-Christian,

I confirm that I sent this patch on October 8th to this list and to LKML 
too (http://lkml.org/lkml/2009/10/8/67).

Then, the patch has been re-sent by Nicolas on October 9th 
(http://lkml.org/lkml/2009/10/9/86) and finally applied by Jiri Kosina 
(http://lkml.org/lkml/2009/10/9/218).

Many thanks anyway.

Best regards,

Claudio

------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay 
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference