From: Roel Kluin <roel.kluin@gmail.com>
To: Joseph Chan <JosephChan@via.com.tw>,
Scott Fang <ScottFang@viatech.com.cn>,
linux-fbdev-devel@lists.sourceforge.net,
Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vge>
Subject: [PATCH] viafb: Use sizeof struct rather than pointer
Date: Sat, 21 Nov 2009 20:01:05 +0100 [thread overview]
Message-ID: <4B0838F1.4090202@gmail.com> (raw)
The sizeof the struct should be used rather than of the pointer
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
drivers/video/via/viafbdev.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
Unless I am mistaken?
diff --git a/drivers/video/via/viafbdev.c b/drivers/video/via/viafbdev.c
index 56ec696..6cf4cb8 100644
--- a/drivers/video/via/viafbdev.c
+++ b/drivers/video/via/viafbdev.c
@@ -680,7 +680,7 @@ static int viafb_ioctl(struct fb_info *info, u_int cmd, u_long arg)
if (!viafb_gamma_table)
return -ENOMEM;
if (copy_from_user(viafb_gamma_table, argp,
- sizeof(viafb_gamma_table))) {
+ sizeof(*viafb_gamma_table))) {
kfree(viafb_gamma_table);
return -EFAULT;
}
next reply other threads:[~2009-11-21 19:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-21 19:01 Roel Kluin [this message]
2009-11-21 19:02 ` [PATCH] viafb: Use sizeof struct rather than pointer Roel Kluin
2009-11-21 18:53 ` Thiago Farina
2009-11-21 23:59 ` [Linux-fbdev-devel] " Florian Tobias Schandinat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B0838F1.4090202@gmail.com \
--to=roel.kluin@gmail.com \
--cc=JosephChan@via.com.tw \
--cc=ScottFang@viatech.com.cn \
--cc=akpm@linux-foundation.org \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=linux-kernel@vge \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).