From mboxrd@z Thu Jan 1 00:00:00 1970 From: Florian Tobias Schandinat Subject: Re: [PATCH 05/16] viafb: Determine type of 2D engine and store it in chip_info Date: Sun, 18 Apr 2010 20:05:34 +0200 Message-ID: <4BCB49EE.8050006@gmx.de> References: <1270746946-12467-1-git-send-email-corbet@lwn.net> <1270746946-12467-6-git-send-email-corbet@lwn.net> <4BBE9CFC.2020804@gmx.de> <20100409141127.42e4e1fa@bike.lwn.net> <4BBF8F48.2070902@gmx.de> <20100418113430.53760f99@bike.lwn.net> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20100418113430.53760f99@bike.lwn.net> Sender: linux-kernel-owner@vger.kernel.org List-ID: Content-Type: text/plain; charset="us-ascii"; format="flowed" To: Jonathan Corbet Cc: linux-kernel@vger.kernel.org, Harald Welte , JosephChan@via.com.tw, ScottFang@viatech.com.cn, Deepak Saxena , linux-fbdev-devel@lists.sourceforge.net Jonathan Corbet schrieb: > [Getting back to the older stuff...] > > On Fri, 09 Apr 2010 22:34:16 +0200 > Florian Tobias Schandinat wrote: > >>>> Just a minor nit: >>>> Could we change the default so that if someone adds support for a new >>>> IGP (and misses this function) we default to either the newest or >>>> preferably to none? I've just seen too much poorly maintained code in >>>> this driver and defaulting to the oldest is hence a bad idea. >>>> Otherwise it's fine. > > In the absence of that, the only course of action which makes sense is > to simply fail the initialization if an unknown chip type shows up > there. That's easy, and I can do it. But, given that this was a > "minor nit," can we leave it as-is for now? Yes, if you feel too uncomfortable with changing it and agree that the whole stuff should be made more maintainable later on I am okay with letting this in as is. > There's a *lot* of things to clean up in this driver, I'd like to make it > better a step at a time rather than trying to do the whole thing at once. This is indeed very true. Thanks, Florian Tobias Schandinat