From: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
To: Jonathan Corbet <corbet@lwn.net>
Cc: linux-kernel@vger.kernel.org, Harald Welte <laforge@gnumonks.org>,
Deepak Saxena <dsaxena@laptop.org>,
linux-fbdev@vger.kernel.org, JosephChan@via.com.tw,
ScottFang@viatech.com.cn
Subject: Re: [PATCH 10/11] viafb: rework the I2C support in the VIA framebuffer
Date: Sat, 24 Apr 2010 10:47:34 +0000 [thread overview]
Message-ID: <4BD2CC46.4060908@gmx.de> (raw)
In-Reply-To: <4BD22B96.5020102@gmx.de>
Florian Tobias Schandinat schrieb:
> Jonathan Corbet schrieb:
>> On Sat, 24 Apr 2010 00:40:39 +0200
>> Florian Tobias Schandinat <FlorianSchandinat@gmx.de> wrote:
>> Meanwhile, I'm a little unsure now...is there an action item for me
>> with regard to the i2c code? I've been staring at it since your last
>> note, but I couldn't find any obvious problems. I do have to say that
>> Harald's rework is far cleaner than what came before...
>
> Well the main question is probably:
> How does it change the behaviour towards the hardware?
> I tend to think that OLPC might not be the only ones who did something
> weird with it....and we already know that we shouldn't trust the
> documentation too much.
I was able to narrow this issue down to the fourth bus. So with
if (i = 4)
continue;
in the bus creation loop I'm able to get a working framebuffer which
does not have the issues mentioned. Any ideas what should be done now?
Thanks,
Florian Tobias Schandinat
next prev parent reply other threads:[~2010-04-24 10:47 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-18 18:21 [RFC] Initial OLPC Viafb merge (V2) Jonathan Corbet
2010-04-18 18:21 ` [PATCH 01/11] [FB] viafb: Fix various resource leaks during module_init() Jonathan Corbet
2010-04-18 18:21 ` [PATCH 02/11] viafb: use proper pci config API Jonathan Corbet
2010-04-18 18:21 ` [PATCH 03/11] viafb: Unmap the frame buffer on initialization error Jonathan Corbet
2010-04-18 18:21 ` [PATCH 04/11] viafb: Retain GEMODE reserved bits Jonathan Corbet
2010-04-18 18:21 ` [PATCH 05/11] viafb: Unify duplicated set_bpp() code Jonathan Corbet
2010-04-18 18:21 ` [PATCH 06/11] viafb: Determine type of 2D engine and store it in chip_info Jonathan Corbet
2010-04-18 18:21 ` [PATCH 07/11] viafb: complete support for VX800/VX855 accelerated framebuffer Jonathan Corbet
2010-04-18 18:21 ` [PATCH 08/11] viafb: Add 1200x900 DCON/LCD panel modes for OLPC XO-1.5 Jonathan Corbet
2010-04-18 18:21 ` [PATCH 09/11] viafb: Do not probe for LVDS/TMDS on " Jonathan Corbet
2010-04-23 20:56 ` Florian Tobias Schandinat
2010-04-23 21:09 ` Jonathan Corbet
2010-04-18 18:21 ` [PATCH 10/11] viafb: rework the I2C support in the VIA framebuffer driver Jonathan Corbet
2010-04-23 21:12 ` [PATCH 10/11] viafb: rework the I2C support in the VIA framebuffer Florian Tobias Schandinat
2010-04-23 21:57 ` [PATCH 10/11] viafb: rework the I2C support in the VIA Jonathan Corbet
2010-04-23 22:40 ` [PATCH 10/11] viafb: rework the I2C support in the VIA framebuffer Florian Tobias Schandinat
2010-04-23 22:52 ` [PATCH 10/11] viafb: rework the I2C support in the VIA Jonathan Corbet
2010-04-23 23:21 ` [PATCH 10/11] viafb: rework the I2C support in the VIA framebuffer Florian Tobias Schandinat
2010-04-24 10:47 ` Florian Tobias Schandinat [this message]
2010-04-24 13:33 ` [PATCH 10/11] viafb: rework the I2C support in the VIA Jonathan Corbet
2010-04-24 13:53 ` Harald Welte
2010-04-25 14:38 ` Jonathan Corbet
2010-04-25 15:56 ` [PATCH 10/11] viafb: rework the I2C support in the VIA framebuffer Florian Tobias Schandinat
2010-04-26 19:40 ` [PATCH 10/11] viafb: rework the I2C support in the VIA Jonathan Corbet
2010-04-18 18:21 ` [PATCH 11/11] suppress verbose debug messages: change printk() to DEBUG_MSG() Jonathan Corbet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BD2CC46.4060908@gmx.de \
--to=florianschandinat@gmx.de \
--cc=JosephChan@via.com.tw \
--cc=ScottFang@viatech.com.cn \
--cc=corbet@lwn.net \
--cc=dsaxena@laptop.org \
--cc=laforge@gnumonks.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).