From: Roger Quadros <roger.quadros@nokia.com>
To: "ext Peter Hüwe" <PeterHuewe@gmx.de>
Cc: "Valkeinen Tomi (Nokia-D/Helsinki)" <Tomi.Valkeinen@nokia.com>,
"tony@atomide.com" <tony@atomide.com>,
"khilman@deeprootsystems.com" <khilman@deeprootsystems.com>,
"paul@pwsan.com" <paul@pwsan.com>,
"jpihet@mvista.com" <jpihet@mvista.com>,
"kalle.valo@iki.fi" <kalle.valo@iki.fi>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"linux-fbdev@vger.kernel.org" <linux-fbdev@vger.kernel.org>
Subject: Re: Buildfailure for omap3_defconfig due to patch OMAP: RX51: Add
Date: Thu, 13 May 2010 07:35:02 +0000 [thread overview]
Message-ID: <4BEBABA6.6040907@nokia.com> (raw)
In-Reply-To: <201005122331.51347.PeterHuewe@gmx.de>
Hi Peter,
ext Peter Hüwe wrote:
> Hi Roger,
>
> I just wanted to inform you that your Patch
> OMAP: RX51: Add LCD Panel support (b499d77834ae292465f8d06bb0a88f1a647dfa1a)
> introduces a build failure for the omap3_defconfig.
>
> You can see the error message here:
> http://kisskb.ellerman.id.au/kisskb/buildresult/2601981/
>
> This is due to the fact that omap3_defconfig has
> CONFIG_MACH_NOKIA_RX51=y
> set which enables the compilation of arch/arm/mach-omap2/board-rx51.c
>
> board-rx51.c calls rx51_video_mem_init in arch/arm/mach-omap2/board-rx51-
> video.c which is guarded by
> #if defined(CONFIG_FB_OMAP2) || defined(CONFIG_FB_OMAP2_MODULE)
>
> Unfortunately none if them is set in the omap3_defconfig.
>
> Would be nice if you could fix this :)
>
Thanks for pointing this out. Kevin Hilman had already informed me of this earlier.
The patch with the fix is here
https://patchwork.kernel.org/patch/98092/
Tomi has picked up the fixed patch in his tree in the for-next branch
http://gitorious.org/linux-omap-dss2/linux/commit/9585a7e56c51d224830adb29b1843310a87cd034
regards,
-roger
prev parent reply other threads:[~2010-05-13 7:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-12 21:31 Buildfailure for omap3_defconfig due to patch OMAP: RX51: Add LCD Panel support Peter Hüwe
2010-05-12 21:51 ` Peter Hüwe
2010-05-13 7:35 ` Roger Quadros [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BEBABA6.6040907@nokia.com \
--to=roger.quadros@nokia.com \
--cc=PeterHuewe@gmx.de \
--cc=Tomi.Valkeinen@nokia.com \
--cc=jpihet@mvista.com \
--cc=kalle.valo@iki.fi \
--cc=khilman@deeprootsystems.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pwsan.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).