Buildfailure for omap3_defconfig due to patch OMAP: RX51: Add LCD Panel support

Buildfailure for omap3_defconfig due to patch OMAP: RX51: Add LCD Panel support

[Peter Hüwe]

Hi Roger,

I just wanted to inform you that your Patch
OMAP: RX51: Add LCD Panel support (b499d77834ae292465f8d06bb0a88f1a647dfa1a) 
introduces a build failure for the omap3_defconfig.

You can see the error message here:
http://kisskb.ellerman.id.au/kisskb/buildresult/2601981/

This is due to the fact that omap3_defconfig has
CONFIG_MACH_NOKIA_RX51=y
set which enables the compilation of arch/arm/mach-omap2/board-rx51.c

board-rx51.c calls rx51_video_mem_init in arch/arm/mach-omap2/board-rx51-
video.c which is guarded by 
#if defined(CONFIG_FB_OMAP2) || defined(CONFIG_FB_OMAP2_MODULE)

Unfortunately none if them is set in the omap3_defconfig.

Would be nice if you could fix this :)

Thanks,
Peter

Reported-by: Peter Huewe <peterhuewe@gmx.de>

Re: Buildfailure for omap3_defconfig due to patch OMAP: RX51: Add LCD Panel support

[Peter Hüwe]

Unfortunately I can't get through the nokia mailfilter:
Message_contained_possible_malicious_content_and_will_not_be_accepted._If_you_consider_this_to_be_due_to_an_error_please_inform_the_intended_recipients_by_sending_a_simple_e-
mail_or_through_other_means/

I get this reply even with a simple "hello your mail filter does not like me" 
message :/

Can somebody else please try to forward the message to Roger and Tomi?

Thanks,
Peter


Am Mittwoch 12 Mai 2010 23:31:51 schrieb Peter Hüwe:
> Hi Roger,
> 
> I just wanted to inform you that your Patch
> OMAP: RX51: Add LCD Panel support
>  (b499d77834ae292465f8d06bb0a88f1a647dfa1a) introduces a build failure for
>  the omap3_defconfig.
> 
> You can see the error message here:
> http://kisskb.ellerman.id.au/kisskb/buildresult/2601981/
> 

Re: Buildfailure for omap3_defconfig due to patch OMAP: RX51: Add

[Roger Quadros]

Hi Peter,

ext Peter Hüwe wrote:
> Hi Roger,
> 
> I just wanted to inform you that your Patch
> OMAP: RX51: Add LCD Panel support (b499d77834ae292465f8d06bb0a88f1a647dfa1a) 
> introduces a build failure for the omap3_defconfig.
> 
> You can see the error message here:
> http://kisskb.ellerman.id.au/kisskb/buildresult/2601981/
> 
> This is due to the fact that omap3_defconfig has
> CONFIG_MACH_NOKIA_RX51=y
> set which enables the compilation of arch/arm/mach-omap2/board-rx51.c
> 
> board-rx51.c calls rx51_video_mem_init in arch/arm/mach-omap2/board-rx51-
> video.c which is guarded by 
> #if defined(CONFIG_FB_OMAP2) || defined(CONFIG_FB_OMAP2_MODULE)
> 
> Unfortunately none if them is set in the omap3_defconfig.
> 
> Would be nice if you could fix this :)
> 
Thanks for pointing this out. Kevin Hilman had already informed me of this earlier.

The patch with the fix is here
https://patchwork.kernel.org/patch/98092/

Tomi has picked up the fixed patch in his tree in the for-next branch
http://gitorious.org/linux-omap-dss2/linux/commit/9585a7e56c51d224830adb29b1843310a87cd034

regards,
-roger