From: Mauro Carvalho Chehab <mchehab@redhat.com>
To: Jonathan Corbet <corbet@lwn.net>
Cc: linux-kernel@vger.kernel.org,
"Harald Welte" <laforge@gnumonks.org>,
linux-fbdev@vger.kernel.org, JosephChan@via.com.tw,
ScottFang@viatech.com.cn,
"Bruno Prémont" <bonbons@linux-vserver.org>,
"Florian Tobias Schandinat" <FlorianSchandinat@gmx.de>,
linux-media@vger.kernel.org
Subject: Re: [PATCH 5/5] Add the viafb video capture driver
Date: Tue, 25 May 2010 01:02:07 +0000 [thread overview]
Message-ID: <4BFB218F.6030800@redhat.com> (raw)
In-Reply-To: <20100524172237.7c17cd57@bike.lwn.net>
Jonathan Corbet wrote:
> On Sun, 23 May 2010 09:51:47 -0300
> Mauro Carvalho Chehab <mchehab@redhat.com> wrote:
>
>> The driver is OK to my eyes. I just found 2 minor coding style issues.
>> it is ok to me if you want to sent it via your git tree.
>>
>> Acked-by: Mauro Carvalho Chehab <mchehab@redhat.com>
>
> Great, thanks for taking a look!
>
> All of the precursor stuff is in mainline now, so it can go via whatever
> path. I'll just go ahead and request a pull in the near future unless
> somebody objects.
OK.
>>> + .sizeimage = VGA_WIDTH*VGA_HEIGHT*2,
>> CodingStyle: please use spaces between values/operators. Not sure why, but
>> newer versions of checkpatch.pl don't complain anymore on some cases.
>
> Interesting...for all of my programming life I've left out spaces around
> multiplicative operators - a way of showing that they bind more tightly
> than the additive variety. I thought everybody else did that too.
> CodingStyle agrees with you, though; I'll append a patch fixing these up.
We all have some sort of different CodingStyle that were inherited from previous
programming practices... I used to just not add any space at all at expressions,
as C is a compact language, and I was a bit lazy ;)
Yet, when reviewing lots of code, those spaces help to read a code quicker
than without. Not sure why, but my guess is that the brain can do a faster
parsing when the words are separated from operators. Or maybe it is just because
it is easier to parse patches when everybody uses the same Coding Style.
> Learn something every day...
Very true ;)
--
Cheers,
Mauro
prev parent reply other threads:[~2010-05-25 1:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-05 22:34 [RFC] Third OLPC viafb patch series (camera driver) Jonathan Corbet
2010-05-05 22:34 ` [PATCH 1/5] viafb: fold via_io.h into via-core.h Jonathan Corbet
2010-05-05 22:34 ` [PATCH 2/5] viafb: get rid of i2c debug cruft Jonathan Corbet
2010-05-05 22:34 ` [PATCH 3/5] viafb: Eliminate some global.h references Jonathan Corbet
2010-05-05 22:34 ` [PATCH 4/5] viafb: move some include files to include/linux Jonathan Corbet
2010-05-05 22:34 ` [PATCH 5/5] Add the viafb video capture driver Jonathan Corbet
2010-05-23 12:51 ` Mauro Carvalho Chehab
2010-05-24 23:22 ` Jonathan Corbet
2010-05-25 1:02 ` Mauro Carvalho Chehab [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BFB218F.6030800@redhat.com \
--to=mchehab@redhat.com \
--cc=FlorianSchandinat@gmx.de \
--cc=JosephChan@via.com.tw \
--cc=ScottFang@viatech.com.cn \
--cc=bonbons@linux-vserver.org \
--cc=corbet@lwn.net \
--cc=laforge@gnumonks.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).