From mboxrd@z Thu Jan 1 00:00:00 1970 From: Randy Dunlap Date: Tue, 01 Jun 2010 21:41:18 +0000 Subject: Re: [PATCH] fbdev: fix frame buffer devices menu Message-Id: <4C057E7E.3030007@oracle.com> List-Id: References: <1274896477-6832-1-git-send-email-cascardo@holoscopio.com> <20100527040329.GA14841@jasper.tkos.co.il> <20100601142806.03c50a49.akpm@linux-foundation.org> In-Reply-To: <20100601142806.03c50a49.akpm@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Andrew Morton Cc: Baruch Siach , Thadeu Lima de Souza Cascardo , linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, =?ISO-8859-1?Q?Uwe_Kleine-K=F6nig?= , Sascha Hauer Andrew Morton wrote: > On Thu, 27 May 2010 07:03:29 +0300 > Baruch Siach wrote: > >> On Wed, May 26, 2010 at 02:54:37PM -0300, Thadeu Lima de Souza Cascardo wrote: >>> Commit f601441916d1e19291d0b4f044b4a7551e2924d0 has inserted the symbol >>> HAVE_FB_IMX, which does not depend on FB after the menuconfig FB. This >>> breaks the menu, presenting most of the drivers outside of it, when >>> using menuconfig. >>> >>> Moving the symbol to the start of the file, just like HAVE_FB_ATMEL, >>> fixes the problem without breaking it for iMX25 configurations (tested >>> with ARCH=arm, no build). >>> >>> Cc: Baruch Siach >>> Cc: Uwe Kleine-K__nig >>> Cc: Sascha Hauer >>> Signed-off-by: Thadeu Lima de Souza Cascardo >> Acked-by: Baruch Siach >> > > OK, I've been sitting on the below patch > (fbdev-fix-kconfig-breakage-in-drivers-video.patch) for months, waiting > for Krzysztof to respond to some comment which Baruch made, but > Krzysztof seems to have gone quiet. > > Could you guys please compare Thadeu's patch with the below and work > out which is preferable and whether the new patch has the same coverage > as the old one, etc? > > Thanks. > > > > From: Krzysztof Helt > > There are two new options inside the CONFIG_FB section which do not depend > on the CONFIG_FB. This break Kconfig menu layout. > > Fix it and reduce few conditions for sparc frame buffers as the FB_SBUS = > ((FB = y) && SPARC). > > Signed-off-by: Krzysztof Helt > Acked-by: David S. Miller > Signed-off-by: Andrew Morton > --- > > drivers/video/Kconfig | 11 ++++------- > 1 file changed, 4 insertions(+), 7 deletions(-) This patch is missing a compatible change to arch/arm/plat-mxc/Kconfig: config ARCH_MX25 bool "MX25-based" select CPU_ARM926T select ARCH_MXC_IOMUX_V3 select HAVE_FB_IMX help This enables support for systems based on the Freescale i.MX25 family so the "select HAVE_FB_IMX" does nothing and there is no handling for this config below AFAICT. > diff -puN drivers/video/Kconfig~fbdev-fix-kconfig-breakage-in-drivers-video drivers/video/Kconfig > --- a/drivers/video/Kconfig~fbdev-fix-kconfig-breakage-in-drivers-video > +++ a/drivers/video/Kconfig > @@ -400,12 +400,9 @@ config FB_SA1100 > If you plan to use the LCD display with your SA-1100 system, say > Y here. > > -config HAVE_FB_IMX > - bool > - > config FB_IMX > tristate "Motorola i.MX LCD support" > - depends on FB && (HAVE_FB_IMX || ARCH_MX1 || ARCH_MX2) > + depends on FB && (ARCH_MX1 || ARCH_MX2) > select FB_CFB_FILLRECT > select FB_CFB_COPYAREA > select FB_CFB_IMAGEBLIT > @@ -802,7 +799,7 @@ config FB_SBUS > > config FB_BW2 > bool "BWtwo support" > - depends on (FB = y) && (SPARC && FB_SBUS) > + depends on FB_SBUS > select FB_CFB_FILLRECT > select FB_CFB_COPYAREA > select FB_CFB_IMAGEBLIT > @@ -811,7 +808,7 @@ config FB_BW2 > > config FB_CG3 > bool "CGthree support" > - depends on (FB = y) && (SPARC && FB_SBUS) > + depends on FB_SBUS > select FB_CFB_FILLRECT > select FB_CFB_COPYAREA > select FB_CFB_IMAGEBLIT > @@ -820,7 +817,7 @@ config FB_CG3 > > config FB_CG6 > bool "CGsix (GX,TurboGX) support" > - depends on (FB = y) && (SPARC && FB_SBUS) > + depends on FB_SBUS > select FB_CFB_COPYAREA > select FB_CFB_IMAGEBLIT > help > _