From: Ben Dooks <ben@simtec.co.uk>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 05/12] s3c-fb: Add support for display panning
Date: Fri, 02 Jul 2010 11:25:33 +0000 [thread overview]
Message-ID: <4C2DCCAD.9080306@simtec.co.uk> (raw)
In-Reply-To: <4C288779.8040702@gmail.com>
On 28/06/10 12:28, Maurus Cuelenaere wrote:
> Op 28-06-10 10:08, Pawel Osciak schreef:
>> Supports all bpp modes.
>>
>> The PRTCON register is used to disable in-hardware updates of registers
>> that store start and end addresses of framebuffer memory. This prevents
>> display corruption in case we do not make it before VSYNC with updating
>> them atomically. With this feature there is no need to wait for a VSYNC
>> interrupt before each such update.
>>
>> Signed-off-by: Pawel Osciak <p.osciak@samsung.com>
>> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
>> ---
>> arch/arm/plat-samsung/include/plat/regs-fb.h | 5 ++
>> drivers/video/s3c-fb.c | 71 ++++++++++++++++++++++++++
>> 2 files changed, 76 insertions(+), 0 deletions(-)
>>
>> diff --git a/arch/arm/plat-samsung/include/plat/regs-fb.h b/arch/arm/plat-samsung/include/plat/regs-fb.h
>> index ac10013..f454e32 100644
>> --- a/arch/arm/plat-samsung/include/plat/regs-fb.h
>> +++ b/arch/arm/plat-samsung/include/plat/regs-fb.h
>> @@ -112,6 +112,11 @@
>> #define VIDCON2_ORGYCbCr (1 << 8)
>> #define VIDCON2_YUVORDCrCb (1 << 7)
>>
>> +/* PRTCON (S3C6410, S5PC100) */
>> +
>> +#define PRTCON (0x0c)
>> +#define PRTCON_PROTECT (1 << 11)
>> +
>> /* VIDTCON0 */
>>
>> #define VIDTCON0_VBPDE_MASK (0xff << 24)
>> diff --git a/drivers/video/s3c-fb.c b/drivers/video/s3c-fb.c
>> index 59ac76a..4f3680d 100644
>> --- a/drivers/video/s3c-fb.c
>> +++ b/drivers/video/s3c-fb.c
>> @@ -71,6 +71,7 @@ struct s3c_fb;
>> * @buf_end: Offset of buffer end registers.
>> * @osd: The base for the OSD registers.
>> * @palette: Address of palette memory, or 0 if none.
>> + * @has_prtcon: Set if has PRTCON register.
>> */
>> struct s3c_fb_variant {
>> unsigned int is_2443:1;
>> @@ -85,6 +86,8 @@ struct s3c_fb_variant {
>> unsigned short osd;
>> unsigned short osd_stride;
>> unsigned short palette[S3C_FB_MAX_WIN];
>> +
>> + unsigned int has_prtcon:1;
>> };
>>
>> /**
>> @@ -379,6 +382,9 @@ static int s3c_fb_set_par(struct fb_info *info)
>>
>> info->fix.line_length = (var->xres_virtual * var->bits_per_pixel) / 8;
>>
>> + info->fix.xpanstep = info->var.xres_virtual > info->var.xres ? 1 : 0;
>> + info->fix.ypanstep = info->var.yres_virtual > info->var.yres ? 1 : 0;
>
> No need for the '? 1 : 0'
I tihnk there is, IIRC there is no neccessity for a compiler to produce
one for true, just that the result be !0
next prev parent reply other threads:[~2010-07-02 11:25 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-28 8:08 [PATCH v3 0/12] Various s3c-fb updates Pawel Osciak
2010-06-28 8:08 ` [PATCH v3 01/12] s3c-fb: Fix various null references on framebuffer Pawel Osciak
2010-07-02 9:51 ` Ben Dooks
2010-07-02 12:56 ` [PATCH v3 01/12] s3c-fb: Fix various null references on Pawel Osciak
2010-07-06 16:16 ` [PATCH v3 01/12] s3c-fb: Fix various null references on framebuffer James Simmons
2010-06-28 8:08 ` [PATCH v3 02/12] s3c-fb: Correct FRAMESEL1 bitfield defines for Pawel Osciak
2010-07-02 10:51 ` Ben Dooks
2010-06-28 8:08 ` [PATCH v3 03/12] s3c-fb: Separate S5PC100 and S5PV210 framebuffer Pawel Osciak
2010-07-02 11:12 ` Ben Dooks
2010-07-02 13:05 ` Pawel Osciak
2010-06-28 8:08 ` [PATCH v3 04/12] s3c-fb: Add device name initialization Pawel Osciak
2010-07-02 11:13 ` Ben Dooks
2010-06-28 8:08 ` [PATCH v3 05/12] s3c-fb: Add support for display panning Pawel Osciak
2010-06-28 11:28 ` Maurus Cuelenaere
2010-07-02 11:25 ` Ben Dooks [this message]
2010-07-02 11:33 ` Maurus Cuelenaere
2010-07-02 11:52 ` Mark Brown
2010-07-02 11:24 ` Ben Dooks
2010-07-02 13:29 ` Pawel Osciak
2010-07-04 13:50 ` Jamie Lokier
2010-06-28 8:08 ` [PATCH v3 06/12] s3c-fb: Add wait for VSYNC ioctl Pawel Osciak
2010-07-02 11:37 ` Ben Dooks
2010-07-02 14:39 ` Pawel Osciak
2010-06-28 8:08 ` [PATCH v3 07/12] s3c-fb: window 3 of 64xx+ does not have an osd_d Pawel Osciak
2010-06-28 8:08 ` [PATCH v3 08/12] s3c-fb: Add SHADOWCON shadow register locking support Pawel Osciak
2010-07-02 13:11 ` [PATCH v3 08/12] s3c-fb: Add SHADOWCON shadow register locking Ben Dooks
2010-07-02 14:45 ` Pawel Osciak
2010-06-28 8:08 ` [PATCH v3 09/12] s3c-fb: Correct window osd size and alpha register Pawel Osciak
2010-07-02 13:16 ` Ben Dooks
2010-07-02 14:53 ` [PATCH v3 09/12] s3c-fb: Correct window osd size and alpha Pawel Osciak
2010-06-28 8:08 ` [PATCH v3 10/12] s3c-fb: Protect window-specific registers during Pawel Osciak
2010-06-28 8:08 ` [PATCH v3 11/12] s3c-fb: fix section mismatch Pawel Osciak
2010-06-28 8:08 ` [PATCH v3 12/12] s3c-fb: Add support for DMA channel control on S5PV210 Pawel Osciak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C2DCCAD.9080306@simtec.co.uk \
--to=ben@simtec.co.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).