From: Ben Dooks <ben@simtec.co.uk>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 08/12] s3c-fb: Add SHADOWCON shadow register locking
Date: Fri, 02 Jul 2010 13:11:35 +0000 [thread overview]
Message-ID: <4C2DE587.6000306@simtec.co.uk> (raw)
In-Reply-To: <1277712538-23188-9-git-send-email-p.osciak@samsung.com>
On 28/06/10 09:08, Pawel Osciak wrote:
> S5PV210 allows per-window locking of register value updates from shadow
> registers.
>
> Signed-off-by: Pawel Osciak <p.osciak@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> ---
> arch/arm/plat-samsung/include/plat/regs-fb.h | 3 ++
> drivers/video/s3c-fb.c | 39 +++++++++++++++++++++++--
> 2 files changed, 38 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm/plat-samsung/include/plat/regs-fb.h b/arch/arm/plat-samsung/include/plat/regs-fb.h
> index 5bcdd09..da54b64 100644
> --- a/arch/arm/plat-samsung/include/plat/regs-fb.h
> +++ b/arch/arm/plat-samsung/include/plat/regs-fb.h
> @@ -218,6 +218,9 @@
> #define WINCON1_BPPMODE_25BPP_A1888 (0xd << 2)
> #define WINCON1_BPPMODE_28BPP_A4888 (0xd << 2)
>
> +/* S5PV210 */
> +#define SHADOWCON (0x34)
> +#define SHADOWCON_WINx_PROTECT(_win) (1 << (10 + _win))
you should have () around the _win arg.
>
> #define VIDOSDxA_TOPLEFT_X_MASK (0x7ff << 11)
> #define VIDOSDxA_TOPLEFT_X_SHIFT (11)
> diff --git a/drivers/video/s3c-fb.c b/drivers/video/s3c-fb.c
> index 0a93fca..94423c5 100644
> --- a/drivers/video/s3c-fb.c
> +++ b/drivers/video/s3c-fb.c
> @@ -79,6 +79,7 @@ struct s3c_fb;
> * @osd: The base for the OSD registers.
> * @palette: Address of palette memory, or 0 if none.
> * @has_prtcon: Set if has PRTCON register.
> + * @has_shadowcon: Set if has SHADOWCON register.
> */
> struct s3c_fb_variant {
> unsigned int is_2443:1;
> @@ -95,6 +96,7 @@ struct s3c_fb_variant {
> unsigned short palette[S3C_FB_MAX_WIN];
>
> unsigned int has_prtcon:1;
> + unsigned int has_shadowcon:1;
> };
>
> /**
> @@ -363,6 +365,36 @@ static int s3c_fb_align_word(unsigned int bpp, unsigned int pix)
> }
>
> /**
> + * shadow_protect_win() - disable updating values from shadow registers at vsync
> + *
> + * @win: window to protect registers for
> + * @protect: 1 to protect (disable updates)
> + */
> +static void shadow_protect_win(struct s3c_fb_win *win, int protect)
technically, protect should be of type 'bool'/
next prev parent reply other threads:[~2010-07-02 13:11 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-28 8:08 [PATCH v3 0/12] Various s3c-fb updates Pawel Osciak
2010-06-28 8:08 ` [PATCH v3 01/12] s3c-fb: Fix various null references on framebuffer Pawel Osciak
2010-07-02 9:51 ` Ben Dooks
2010-07-02 12:56 ` [PATCH v3 01/12] s3c-fb: Fix various null references on Pawel Osciak
2010-07-06 16:16 ` [PATCH v3 01/12] s3c-fb: Fix various null references on framebuffer James Simmons
2010-06-28 8:08 ` [PATCH v3 02/12] s3c-fb: Correct FRAMESEL1 bitfield defines for Pawel Osciak
2010-07-02 10:51 ` Ben Dooks
2010-06-28 8:08 ` [PATCH v3 03/12] s3c-fb: Separate S5PC100 and S5PV210 framebuffer Pawel Osciak
2010-07-02 11:12 ` Ben Dooks
2010-07-02 13:05 ` Pawel Osciak
2010-06-28 8:08 ` [PATCH v3 04/12] s3c-fb: Add device name initialization Pawel Osciak
2010-07-02 11:13 ` Ben Dooks
2010-06-28 8:08 ` [PATCH v3 05/12] s3c-fb: Add support for display panning Pawel Osciak
2010-06-28 11:28 ` Maurus Cuelenaere
2010-07-02 11:25 ` Ben Dooks
2010-07-02 11:33 ` Maurus Cuelenaere
2010-07-02 11:52 ` Mark Brown
2010-07-02 11:24 ` Ben Dooks
2010-07-02 13:29 ` Pawel Osciak
2010-07-04 13:50 ` Jamie Lokier
2010-06-28 8:08 ` [PATCH v3 06/12] s3c-fb: Add wait for VSYNC ioctl Pawel Osciak
2010-07-02 11:37 ` Ben Dooks
2010-07-02 14:39 ` Pawel Osciak
2010-06-28 8:08 ` [PATCH v3 07/12] s3c-fb: window 3 of 64xx+ does not have an osd_d Pawel Osciak
2010-06-28 8:08 ` [PATCH v3 08/12] s3c-fb: Add SHADOWCON shadow register locking support Pawel Osciak
2010-07-02 13:11 ` Ben Dooks [this message]
2010-07-02 14:45 ` [PATCH v3 08/12] s3c-fb: Add SHADOWCON shadow register locking Pawel Osciak
2010-06-28 8:08 ` [PATCH v3 09/12] s3c-fb: Correct window osd size and alpha register Pawel Osciak
2010-07-02 13:16 ` Ben Dooks
2010-07-02 14:53 ` [PATCH v3 09/12] s3c-fb: Correct window osd size and alpha Pawel Osciak
2010-06-28 8:08 ` [PATCH v3 10/12] s3c-fb: Protect window-specific registers during Pawel Osciak
2010-06-28 8:08 ` [PATCH v3 11/12] s3c-fb: fix section mismatch Pawel Osciak
2010-06-28 8:08 ` [PATCH v3 12/12] s3c-fb: Add support for DMA channel control on S5PV210 Pawel Osciak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C2DE587.6000306@simtec.co.uk \
--to=ben@simtec.co.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).