[PATCH] [ARM] video/omap2/tdo35s: fix visual artefacts

[PATCH] [ARM] video/omap2/tdo35s: fix visual artefacts

[Igor Grinberg]

TDO35S samples the data on the falling adge of the pixel clock,
therefore the data strobe should be on the raising edge.

Signed-off-by: Igor Grinberg <grinberg@compulab.co.il>
Signed-off-by: Mike Rapoport <mike@compulab.co.il>
---
 .../video/omap2/displays/panel-toppoly-tdo35s.c    |    8 ++++++--
 1 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/drivers/video/omap2/displays/panel-toppoly-tdo35s.c b/drivers/video/omap2/displays/panel-toppoly-tdo35s.c
index fa434ca..e320e67 100644
--- a/drivers/video/omap2/displays/panel-toppoly-tdo35s.c
+++ b/drivers/video/omap2/displays/panel-toppoly-tdo35s.c
@@ -73,8 +73,12 @@ static void toppoly_tdo_panel_power_off(struct omap_dss_device *dssdev)
 
 static int toppoly_tdo_panel_probe(struct omap_dss_device *dssdev)
 {
-	dssdev->panel.config = OMAP_DSS_LCD_TFT | OMAP_DSS_LCD_IVS |
-		OMAP_DSS_LCD_IHS;
+	dssdev->panel.config = OMAP_DSS_LCD_TFT |
+			       OMAP_DSS_LCD_IVS |
+			       OMAP_DSS_LCD_IHS |
+			       OMAP_DSS_LCD_IPC |
+			       OMAP_DSS_LCD_ONOFF;
+
 	dssdev->panel.timings = toppoly_tdo_panel_timings;
 
 	return 0;
-- 
1.7.1

Re: [PATCH] [ARM] video/omap2/tdo35s: fix visual artefacts

[Igor Grinberg]

Tomi,

Any comments?

> TDO35S samples the data on the falling adge of the pixel clock,
> therefore the data strobe should be on the raising edge.
>
> Signed-off-by: Igor Grinberg <grinberg@compulab.co.il>
> Signed-off-by: Mike Rapoport <mike@compulab.co.il>
> ---
>  .../video/omap2/displays/panel-toppoly-tdo35s.c    |    8 ++++++--
>  1 files changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/video/omap2/displays/panel-toppoly-tdo35s.c b/drivers/video/omap2/displays/panel-toppoly-tdo35s.c
> index fa434ca..e320e67 100644
> --- a/drivers/video/omap2/displays/panel-toppoly-tdo35s.c
> +++ b/drivers/video/omap2/displays/panel-toppoly-tdo35s.c
> @@ -73,8 +73,12 @@ static void toppoly_tdo_panel_power_off(struct omap_dss_device *dssdev)
>  
>  static int toppoly_tdo_panel_probe(struct omap_dss_device *dssdev)
>  {
> -	dssdev->panel.config = OMAP_DSS_LCD_TFT | OMAP_DSS_LCD_IVS |
> -		OMAP_DSS_LCD_IHS;
> +	dssdev->panel.config = OMAP_DSS_LCD_TFT |
> +			       OMAP_DSS_LCD_IVS |
> +			       OMAP_DSS_LCD_IHS |
> +			       OMAP_DSS_LCD_IPC |
> +			       OMAP_DSS_LCD_ONOFF;
> +
>  	dssdev->panel.timings = toppoly_tdo_panel_timings;
>  
>  	return 0;
>   

-- 
Regards,
Igor.

Re: [PATCH] [ARM] video/omap2/tdo35s: fix visual artefacts

[Igor Grinberg]

ping!
> TDO35S samples the data on the falling adge of the pixel clock,
> therefore the data strobe should be on the raising edge.
>
> Signed-off-by: Igor Grinberg <grinberg@compulab.co.il>
> Signed-off-by: Mike Rapoport <mike@compulab.co.il>
> ---
>  .../video/omap2/displays/panel-toppoly-tdo35s.c    |    8 ++++++--
>  1 files changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/video/omap2/displays/panel-toppoly-tdo35s.c b/drivers/video/omap2/displays/panel-toppoly-tdo35s.c
> index fa434ca..e320e67 100644
> --- a/drivers/video/omap2/displays/panel-toppoly-tdo35s.c
> +++ b/drivers/video/omap2/displays/panel-toppoly-tdo35s.c
> @@ -73,8 +73,12 @@ static void toppoly_tdo_panel_power_off(struct omap_dss_device *dssdev)
>  
>  static int toppoly_tdo_panel_probe(struct omap_dss_device *dssdev)
>  {
> -	dssdev->panel.config = OMAP_DSS_LCD_TFT | OMAP_DSS_LCD_IVS |
> -		OMAP_DSS_LCD_IHS;
> +	dssdev->panel.config = OMAP_DSS_LCD_TFT |
> +			       OMAP_DSS_LCD_IVS |
> +			       OMAP_DSS_LCD_IHS |
> +			       OMAP_DSS_LCD_IPC |
> +			       OMAP_DSS_LCD_ONOFF;
> +
>  	dssdev->panel.timings = toppoly_tdo_panel_timings;
>  
>  	return 0;
>   

-- 
Regards,
Igor.

Re: [PATCH] [ARM] video/omap2/tdo35s: fix visual artefacts

[Tomi Valkeinen]

On Wed, 2010-07-21 at 16:36 +0200, ext Igor Grinberg wrote:
> ping!

Man has to have his vacation!

> > TDO35S samples the data on the falling adge of the pixel clock,
> > therefore the data strobe should be on the raising edge.

Looks fine to me, except I'd like the patch subject to be in line with
the other patches (ie. prefixed by OMAP: DSS2: ...), and I think it
should describe the change more precisely, perhaps something like "fix
the video signal".

I can make those changes as I apply it to my tree, if it's ok to you.

 Tomi

Re: [PATCH] [ARM] video/omap2/tdo35s: fix visual artefacts

[Igor Grinberg]

>
> On Wed, 2010-07-21 at 16:36 +0200, ext Igor Grinberg wrote:
>   
>> ping!
>>     
> Man has to have his vacation!
>
>   

Well, sorry for that...
I had no idea you are on vacation, but I hope you had a good one :)

>>> TDO35S samples the data on the falling adge of the pixel clock,
>>> therefore the data strobe should be on the raising edge.
>>>       
> Looks fine to me, except I'd like the patch subject to be in line with
> the other patches (ie. prefixed by OMAP: DSS2: ...), and I think it
> should describe the change more precisely, perhaps something like "fix
> the video signal".
>
>   

I'm still new to omap and mostly worked on pxa's till now,
so I brought the subject from there...

> I can make those changes as I apply it to my tree, if it's ok to you.
>   

It is completely fine with me :)

>  Tomi
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
>   

-- 
Regards,
Igor.