From: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
To: linux-fbdev@vger.kernel.org
Subject: Re: [PATCH 2/2] viafb: Add OLPC XO-1.5 port configs
Date: Tue, 21 Sep 2010 17:54:55 +0000 [thread overview]
Message-ID: <4C98F16F.7080505@gmx.de> (raw)
In-Reply-To: <20100921153726.21D609D401B@zog.reactivated.net>
(cc'ed Jon)
Daniel Drake schrieb:
> On 21 September 2010 18:15, Florian Tobias Schandinat
> <FlorianSchandinat@gmx.de> wrote:
>> Why? What happens if this patch is not applied?
>> Please understand, that I, as a maintainer, try to avoid platform specific
>> code as much as possible so a little explanation would be good.
>
> Without the patch, the GPIO/I2C lines are not set up correctly so
> we're unable to access the hardware connected there.
*after a deeper look at the patch*
Hm, one of my patches enables 0x26 also as I2C. So the only difference between
the current config and your config is whether 0x2c is GPIO or I2C where your
version make a lot more sense.
Jon, do you agree that this should become the default config?
Handling a GPIO device as such and not as an I2C device sounds right to me,
although we have to take care about the old code which is doing so.
Thanks,
Florian Tobias Schandinat
next prev parent reply other threads:[~2010-09-21 17:54 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-21 15:37 [PATCH 2/2] viafb: Add OLPC XO-1.5 port configs Daniel Drake
2010-09-21 17:15 ` Florian Tobias Schandinat
2010-09-21 17:15 ` Daniel Drake
2010-09-21 17:54 ` Florian Tobias Schandinat [this message]
2010-09-26 14:57 ` Daniel Drake
2010-09-26 15:50 ` Florian Tobias Schandinat
2010-09-26 15:57 ` Daniel Drake
2010-09-26 21:52 ` Jonathan Corbet
2010-09-27 4:55 ` Florian Tobias Schandinat
2010-10-06 21:15 ` Jonathan Corbet
2010-10-27 15:08 ` Daniel Drake
2010-10-28 18:51 ` Jonathan Corbet
2010-10-28 21:54 ` Daniel Drake
2010-10-28 22:04 ` Jonathan Corbet
2010-10-29 14:03 ` Daniel Drake
2010-11-11 14:59 ` Daniel Drake
2010-11-11 16:01 ` Florian Tobias Schandinat
2010-11-11 17:07 ` Daniel Drake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C98F16F.7080505@gmx.de \
--to=florianschandinat@gmx.de \
--cc=linux-fbdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).