From: "Petr Vandrovec" <VANDROVE@vc.cvut.cz>
To: Kronos <kronos@kronoz.cjb.net>
Cc: linux-fbdev-devel@lists.sourceforge.net,
James Simmons <jsimmons@infradead.org>
Subject: Re: [PATCH] matroxfb: New framebuffer_alloc API and class_d
Date: Mon, 15 Sep 2003 22:24:29 +0200 [thread overview]
Message-ID: <4CCE1F5E79@vcnet.vc.cvut.cz> (raw)
On 15 Sep 03 at 22:16, Kronos wrote:
> Hi,
> this patch converts driver/video/matrox to framebuffer_alloc. Now
> fb_info (and minfo) are dynamically allocated. This also voids the need
> of a global matrox_fb_info if CONFIG_FB_MATROX_MULTIHEAD:
^^^ if not defined
Whole point of CONFIG_FB_MATROX_MULTIHEAD is to use static structure
when MULTIHEAD is not set. It generates much faster driver for ia32 due
to smaller register pressure, as driver data can be addressed with fixed
address instructions. So if you are going to always allocate fbcon
dynamically, please also remove CONFIG_FB_MATROX_MULTIHEAD completely,
making it always enabled.
Besides that, what's the point of this change? Making driver slower,
scattering its data over random memory places (so no cache locality...),
or is there some benefit it brings in and which I missed?
Thanks,
Petr Vandrovec
-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf
next reply other threads:[~2003-09-15 20:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-09-15 20:24 Petr Vandrovec [this message]
2003-09-15 20:42 ` [PATCH] matroxfb: New framebuffer_alloc API and class_dev Kronos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CCE1F5E79@vcnet.vc.cvut.cz \
--to=vandrove@vc.cvut.cz \
--cc=jsimmons@infradead.org \
--cc=kronos@kronoz.cjb.net \
--cc=linux-fbdev-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).