From: Sergei Shtylyov <sshtylyov@mvista.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] video: imxfb: Fix the maximum value for yres
Date: Thu, 23 Dec 2010 18:42:22 +0000 [thread overview]
Message-ID: <4D13980E.4010500@ru.mvista.com> (raw)
In-Reply-To: <1293124671-29426-1-git-send-email-fabio.estevam@freescale.com>
Hello.
Fabio Estevam wrote:
> MX27 and MX25 have 10 bits in the YMAX field of LCDC Size Register.
> Fix the maximum value for yres.
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
[...]
> diff --git a/drivers/video/imxfb.c b/drivers/video/imxfb.c
> index 5c363d0..5d2d337 100644
> --- a/drivers/video/imxfb.c
> +++ b/drivers/video/imxfb.c
> @@ -55,8 +55,10 @@
>
> #ifdef CONFIG_ARCH_MX1
> #define SIZE_YMAX(y) ((y) & 0x1ff)
> +#define YMAX_MASK 0x1ff
> #else
> #define SIZE_YMAX(y) ((y) & 0x3ff)
> +#define YMAX_MASK 0x3ff
> #endif
I'd done the following, to avoid the code duplication:
#ifdef CONFIG_ARCH_MX1
#define YMAX_MASK 0x1ff
#else
#define YMAX_MASK 0x3ff
#endif
#define SIZE_YMAX(y) ((y) & YMAX_MASK)
WBR, Sergei
prev parent reply other threads:[~2010-12-23 18:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-23 17:17 [PATCH] video: imxfb: Fix the maximum value for yres Fabio Estevam
2010-12-23 18:42 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D13980E.4010500@ru.mvista.com \
--to=sshtylyov@mvista.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox