From: Randy Dunlap <randy.dunlap@oracle.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Janusz Krzysztofik <jkrzyszt@tis.icnet.pl>,
Richard Purdie <rpurdie@rpsys.net>,
"linux-fbdev@vger.kernel.org" <linux-fbdev@vger.kernel.org>,
linux-kernel@vger.kernel.org,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
Paul Mundt <lethal@linux-sh.org>
Subject: Re: [RESEND #2] [PATCH v2] LEDS: Add output invertion option to backlight
Date: Thu, 06 Jan 2011 21:19:12 +0000 [thread overview]
Message-ID: <4D2631D0.8030701@oracle.com> (raw)
In-Reply-To: <20110106131659.cedf8500.akpm@linux-foundation.org>
On 01/06/11 13:16, Andrew Morton wrote:
> On Thu, 6 Jan 2011 13:08:56 -0800
> Randy Dunlap <randy.dunlap@oracle.com> wrote:
>
>> On Thu, 6 Jan 2011 13:04:40 -0800 Andrew Morton wrote:
>>
>>> On Thu, 9 Dec 2010 14:41:50 +0100
>>> Janusz Krzysztofik <jkrzyszt@tis.icnet.pl> wrote:
>>>
>>>> +static DEVICE_ATTR(invert, 0644, bl_trig_invert_show, bl_trig_invert_store);
>>>
>>> This new sysfs file should be documented. Where would be an
>>> appropriate place for that? Documentation/leds-class.txt doesn't
>>> mention a sysfs API at all.
>>> --
>>
>> in Documentation/ABI/, where all sysfs interface info lives.
>>
>
> Spose so. Documentation/ABI/stable/sysfs-class-backlight does have
> some stuff in it.
>
> Personally I tend to regard Documentation/ABI/ as fairly useless
> incomprehensible stuff, maintained to keep Greg happy ;) It'd be better
> to have a nice little well-maintained document for a subsystem such as
> this which actually explains its operation in a useful-to-humans way.
> Rather than just mechanically filling out forms.
>
> But a Documentation/ABI update is a heck of a lot better than nothing.
Yes, I was giving you the "where it currently lives", not "what is best."
I agree with you.
--
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
next prev parent reply other threads:[~2011-01-06 21:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-09 13:41 [RESEND #2] [PATCH v2] LEDS: Add output invertion option to backlight trigger Janusz Krzysztofik
2011-01-06 7:08 ` Paul Mundt
2011-01-06 12:02 ` [RESEND #2] [PATCH v2] LEDS: Add output invertion option to Richard Purdie
2011-01-06 21:04 ` Andrew Morton
2011-01-06 21:08 ` Randy Dunlap
2011-01-06 21:16 ` Andrew Morton
2011-01-06 21:19 ` Randy Dunlap [this message]
2011-01-10 4:54 ` [PATCH v3] LEDS: Add output invertion option to backlight trigger Janusz Krzysztofik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D2631D0.8030701@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=jkrzyszt@tis.icnet.pl \
--cc=lethal@linux-sh.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).