From: Joe Jin <joe.jin@oracle.com>
To: Joe Jin <joe.jin@oracle.com>
Cc: Ian Campbell <Ian.Campbell@eu.citrix.com>,
"jeremy@goop.org" <jeremy@goop.org>,
"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
"gurudas.pai@oracle.com" <gurudas.pai@oracle.com>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
"guru.anbalagane@oracle.com" <guru.anbalagane@oracle.com>,
"greg.marsden@oracle.com" <greg.marsden@oracle.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-fbdev@vger.kernel.org" <linux-fbdev@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [Xen-devel] Re: [patch] xenfb: fix xenfb suspend/resume race
Date: Fri, 07 Jan 2011 06:43:20 +0000 [thread overview]
Message-ID: <4D26B608.2060500@oracle.com> (raw)
In-Reply-To: <4D2579F1.50900@oracle.com>
On 01/06/11 16:14, Joe Jin wrote:
>
>>
>> No, it papers over the issue, the code should never have been allowed to
>> get this far if the connection to the backend is not yet fully resumed
>> (i.e. when irq = -1).
>>
>> The call to xenfb_send_event should have been gated further up the call
>> chain, AFAICT by the check of info->update_wanted in xenfb_refresh. This
>> suggests that the correct fix is to set info->update_wanted = 0 in
>> xenfb_resume.
>>
>> I said all this in my previous mail and you ignored it. Did you try this
>> approach?
>
Disable xenfb refresh flag before suspend will fix this issue, sent new patch
to you by another mail, please review it.
Thanks,
Joe
next prev parent reply other threads:[~2011-01-07 6:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-30 12:56 [patch] xenfb: fix xenfb suspend/resume race Joe Jin
2010-12-30 16:40 ` Konrad Rzeszutek Wilk
2010-12-31 0:56 ` Joe Jin
2011-01-03 16:34 ` [Xen-devel] " Konrad Rzeszutek Wilk
2011-01-04 0:34 ` Joe Jin
2011-01-04 11:15 ` Ian Campbell
2011-01-06 7:14 ` Joe Jin
2011-01-06 8:02 ` Ian Campbell
2011-01-06 8:14 ` Joe Jin
2011-01-07 6:43 ` Joe Jin [this message]
2011-01-06 8:47 ` [Xen-devel] " Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D26B608.2060500@oracle.com \
--to=joe.jin@oracle.com \
--cc=Ian.Campbell@eu.citrix.com \
--cc=akpm@linux-foundation.org \
--cc=greg.marsden@oracle.com \
--cc=guru.anbalagane@oracle.com \
--cc=gurudas.pai@oracle.com \
--cc=jeremy@goop.org \
--cc=konrad.wilk@oracle.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).