From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Schocher Date: Tue, 25 Jan 2011 07:07:44 +0000 Subject: Re: [PATCH 4/4 v5] powerpc, video: add SM501 support for charon board. Message-Id: <4D3E76C0.7080306@denx.de> List-Id: References: <1291451028-22532-2-git-send-email-hs@denx.de> <1295937946-26934-1-git-send-email-hs@denx.de> <20110125064949.GF11673@linux-sh.org> In-Reply-To: <20110125064949.GF11673-M7jkjyW5wf5g9hUCZPvPmw@public.gmane.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Paul Mundt Cc: linux-fbdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-discuss-mnsaURCQ41sdnm+yROfE0A@public.gmane.org, Samuel Ortiz , Vincent Sanders , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Ben Dooks , linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Hello Paul, Paul Mundt wrote: > On Tue, Jan 25, 2011 at 07:45:46AM +0100, Heiko Schocher wrote: >> @@ -197,6 +198,15 @@ >> #address-cells = <1>; >> }; >> >> + display@1,0 { >> + compatible = "smi,sm501"; >> + reg = <1 0x00000000 0x00800000 >> + 1 0x03e00000 0x00200000>; >> + mode = "640x480-32@60"; >> + interrupts = <1 1 3>; >> + little-endian; >> + }; >> + > > The endian designation looks good, but it still doesn't explain why you > have a remaining CONFIG_PPC_MPC52xx ifdef encapsulating the property > check in the sm501fb patch. It shouldn't be needed at all. If the > platform supports OF then the property will need to be set one way or the > other, so there is no need for any board or CPU ifdeffery within the > driver itself. Argh, of course you are right, thanks! I post an update for the "sm501fb of support" patch. bye, Heiko -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany