* [PATCH 2/6] FBDEV: JZ4740: Initialize jzfb->fb earlier
@ 2011-03-01 12:05 Maurus Cuelenaere
2011-03-01 13:58 ` Lars-Peter Clausen
2011-03-01 17:19 ` Maurus Cuelenaere
0 siblings, 2 replies; 3+ messages in thread
From: Maurus Cuelenaere @ 2011-03-01 12:05 UTC (permalink / raw)
To: linux-fbdev
There's no reason to not do this, and this is needed in the upcoming SLCD
support patches.
Signed-off-by: Maurus Cuelenaere <mcuelenaere@gmail.com>
---
drivers/video/jz4740_fb.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/drivers/video/jz4740_fb.c b/drivers/video/jz4740_fb.c
index 65741d0..cea7b7e 100644
--- a/drivers/video/jz4740_fb.c
+++ b/drivers/video/jz4740_fb.c
@@ -654,6 +654,7 @@ static int __devinit jzfb_probe(struct platform_device *pdev)
fb->flags = FBINFO_DEFAULT;
jzfb = fb->par;
+ jzfb->fb = fb;
jzfb->pdev = pdev;
jzfb->pdata = pdata;
jzfb->mem = mem;
@@ -722,8 +723,6 @@ static int __devinit jzfb_probe(struct platform_device *pdev)
goto err_free_devmem;
}
- jzfb->fb = fb;
-
return 0;
err_free_devmem:
--
1.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 2/6] FBDEV: JZ4740: Initialize jzfb->fb earlier
2011-03-01 12:05 [PATCH 2/6] FBDEV: JZ4740: Initialize jzfb->fb earlier Maurus Cuelenaere
@ 2011-03-01 13:58 ` Lars-Peter Clausen
2011-03-01 17:19 ` Maurus Cuelenaere
1 sibling, 0 replies; 3+ messages in thread
From: Lars-Peter Clausen @ 2011-03-01 13:58 UTC (permalink / raw)
To: linux-fbdev
On 03/01/2011 01:05 PM, Maurus Cuelenaere wrote:
> There's no reason to not do this, and this is needed in the upcoming SLCD
> support patches.
>
Is there any specific reason, why this change can't be done in the patch adding
SLCD support?
- Lars
> Signed-off-by: Maurus Cuelenaere <mcuelenaere@gmail.com>
> ---
> drivers/video/jz4740_fb.c | 3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/video/jz4740_fb.c b/drivers/video/jz4740_fb.c
> index 65741d0..cea7b7e 100644
> --- a/drivers/video/jz4740_fb.c
> +++ b/drivers/video/jz4740_fb.c
> @@ -654,6 +654,7 @@ static int __devinit jzfb_probe(struct platform_device *pdev)
> fb->flags = FBINFO_DEFAULT;
>
> jzfb = fb->par;
> + jzfb->fb = fb;
> jzfb->pdev = pdev;
> jzfb->pdata = pdata;
> jzfb->mem = mem;
> @@ -722,8 +723,6 @@ static int __devinit jzfb_probe(struct platform_device *pdev)
> goto err_free_devmem;
> }
>
> - jzfb->fb = fb;
> -
> return 0;
>
> err_free_devmem:
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 2/6] FBDEV: JZ4740: Initialize jzfb->fb earlier
2011-03-01 12:05 [PATCH 2/6] FBDEV: JZ4740: Initialize jzfb->fb earlier Maurus Cuelenaere
2011-03-01 13:58 ` Lars-Peter Clausen
@ 2011-03-01 17:19 ` Maurus Cuelenaere
1 sibling, 0 replies; 3+ messages in thread
From: Maurus Cuelenaere @ 2011-03-01 17:19 UTC (permalink / raw)
To: linux-fbdev
Op 01-03-11 14:58, Lars-Peter Clausen schreef:
> On 03/01/2011 01:05 PM, Maurus Cuelenaere wrote:
>> There's no reason to not do this, and this is needed in the upcoming SLCD
>> support patches.
>>
> Is there any specific reason, why this change can't be done in the patch adding
> SLCD support?
I've done this separately because this isn't strictly SLCD-only and thought it
deserved its own commit.
Will merge this.
--
Maurus Cuelenaere
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-03-01 17:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-03-01 12:05 [PATCH 2/6] FBDEV: JZ4740: Initialize jzfb->fb earlier Maurus Cuelenaere
2011-03-01 13:58 ` Lars-Peter Clausen
2011-03-01 17:19 ` Maurus Cuelenaere
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).