linux-fbdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
To: Chris Ball <cjb@laptop.org>
Cc: linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] viafb: kill lcd_panel_id
Date: Sun, 13 Mar 2011 17:15:51 +0000	[thread overview]
Message-ID: <4D7CFBC7.2060109@gmx.de> (raw)
In-Reply-To: <m3hbb7xaup.fsf@pullcord.laptop.org>

Hi Chris,

Chris Ball schrieb:
> Hi Florian,
> 
> On Sat, Mar 12 2011, Florian Tobias Schandinat wrote:
>> This patch removes all internal uses of another mostly artificial
>> value. It does duplicate the information of the maximum resolution and
>> it is not flexible as only a few resolutions exist. Hence it is better
>> to remove it and clean the mess up.
>> No runtime change expected.
>>
>> Signed-off-by: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
> 
> We're passing viafb_lcd_panel_id at boot-time on OLPC XO-1.5.
> Won't this break boot for us, and anyone else who needs to use it?

No need to worry. The external interface is kept for compatibility, only the 
internal uses are replace by panel hres/vres which contain the same information 
but are more generic.
I have not yet tested it on OLPC as I did not have the time to compile a new 
kernel for it, but as it works on my VX900 laptop which also uses the 
viafb_lcd_panel_id setting it should be fine.


Thanks,

Florian Tobias Schandinat


  reply	other threads:[~2011-03-13 17:15 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-12 21:22 viafb cleanup patches Florian Tobias Schandinat
2011-03-12 21:22 ` [PATCH 1/4] viafb: kill lcd_panel_id Florian Tobias Schandinat
2011-03-13 16:07   ` Chris Ball
2011-03-13 17:15     ` Florian Tobias Schandinat [this message]
2011-03-14  0:05       ` Chris Ball
2011-03-12 21:22 ` [PATCH 2/4] viafb: remove unused data_mode and device_type Florian Tobias Schandinat
2011-03-12 21:22 ` [PATCH 3/4] viafb: strip some structures Florian Tobias Schandinat
2011-03-12 21:22 ` [PATCH 4/4] viafb: factor lcd scaling parameters out Florian Tobias Schandinat

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D7CFBC7.2060109@gmx.de \
    --to=florianschandinat@gmx.de \
    --cc=cjb@laptop.org \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).