From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andy Lutomirski <luto@MIT.EDU>
Date: Mon, 13 Jun 2011 02:55:37 +0000
Subject: Re: [PATCH] efifb: Fix call to wrong unregister function
Message-Id: <4DF57C29.4070601@mit.edu>
List-Id: <linux-fbdev.vger.kernel.org>
References: <1307875953.1859.6.camel@Tux>
In-Reply-To: <1307875953.1859.6.camel@Tux>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: "wanlong.gao" <wanlong.gao@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org, Maarten Lankhorst <m.b.lankhorst@gmail.com>, Peter Jones <pjones@redhat.com>

On 06/12/2011 06:52 AM, wanlong.gao wrote:
> <snip>
>
> Hi Maarten:
> It registered efifb_device but try to unregistered efifb_driver,
> so I think you should fix it like this?
>
> Signed-off-by: Wanlong Gao<wanlong.gao@gmail.com>
> ---
>   drivers/video/efifb.c |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/video/efifb.c b/drivers/video/efifb.c
> index 69c49df..784139a 100644
> --- a/drivers/video/efifb.c
> +++ b/drivers/video/efifb.c
> @@ -541,7 +541,7 @@ static int __init efifb_init(void)
>   	 */
>   	ret = platform_driver_probe(&efifb_driver, efifb_probe);
>   	if (ret) {
> -		platform_device_unregister(&efifb_driver);
> +		platform_device_unregister(&efifb_device);
>   		return ret;
>   	}
>

Acked-by: Andy Lutomirski <luto@mit.edu>

That's my bug.  Sorry.  I'm not sure why it compiled, though.

--Andy