From: Damian Hobson-Garcia <dhobsong@igel.co.jp>
To: linux-fbdev@vger.kernel.org
Subject: Re: [PATCH 1/4] fbdev: sh_mobile_meram: Replace hardcoded register
Date: Tue, 02 Aug 2011 08:43:51 +0000 [thread overview]
Message-ID: <4E37B8C7.3050408@igel.co.jp> (raw)
Hi Laurent,
> -#define MExxCTL 0x0
> -#define MExxBSIZE 0x4
> -#define MExxMNCF 0x8
> -#define MExxSARA 0x10
> -#define MExxSARB 0x14
> -#define MExxSBSIZE 0x18
[snip]
> +#define MExxCTL 0x400
> +#define MExxBSIZE 0x404
> +#define MExxMNCF 0x408
> +#define MExxSARA 0x410
> +#define MExxSARB 0x414
> +#define MExxSBSIZE 0x418
One small comment on the definition of these register offsets and
explanation of what I was originally thinking. Since each of these
actually reprents a series of registers, one per ICB, (i.e. ME00CTL,
ME01CTL, etc.) it makes sense to me to represent them as an offset from
the base address (0x400) + the start of each ICB address (0x20 * index).
Other than that, looks great.
Thanks very much,
Damian
reply other threads:[~2011-08-02 8:43 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E37B8C7.3050408@igel.co.jp \
--to=dhobsong@igel.co.jp \
--cc=linux-fbdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).