From: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
To: linux-fbdev@vger.kernel.org
Subject: Re: [PATCH] video: s3c-fb: fix transparency length for pixel blending
Date: Sat, 12 Nov 2011 00:21:43 +0000 [thread overview]
Message-ID: <4EBDBC17.2050208@gmx.de> (raw)
In-Reply-To: <1320645781-9528-1-git-send-email-jg1.han@samsung.com>
On 11/07/2011 06:03 AM, Jingoo Han wrote:
> Transparency length is fixed for pixel blending in order to support
> ARGB 8888 format.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Applied this patch.
Thanks,
Florian Tobias Schandinat
> ---
> drivers/video/s3c-fb.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/video/s3c-fb.c b/drivers/video/s3c-fb.c
> index 0753b1c..12eaee0 100644
> --- a/drivers/video/s3c-fb.c
> +++ b/drivers/video/s3c-fb.c
> @@ -621,7 +621,8 @@ static int s3c_fb_set_par(struct fb_info *info)
> } else if (var->transp.length = 1)
> data |= WINCON1_BPPMODE_25BPP_A1888
> | WINCON1_BLD_PIX;
> - else if (var->transp.length = 4)
> + else if ((var->transp.length = 4) ||
> + (var->transp.length = 8))
> data |= WINCON1_BPPMODE_28BPP_A4888
> | WINCON1_BLD_PIX | WINCON1_ALPHA_SEL;
> else
prev parent reply other threads:[~2011-11-12 0:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-07 6:03 [PATCH] video: s3c-fb: fix transparency length for pixel blending Jingoo Han
2011-11-12 0:21 ` Florian Tobias Schandinat [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EBDBC17.2050208@gmx.de \
--to=florianschandinat@gmx.de \
--cc=linux-fbdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).