From mboxrd@z Thu Jan 1 00:00:00 1970 From: Archit Taneja Date: Wed, 23 Nov 2011 05:51:26 +0000 Subject: Re: [PATCH 08/65] OMAPDSS: remove partial update from panel-taal Message-Id: <4ECC8979.2080905@ti.com> List-Id: References: <1321953724-6350-1-git-send-email-tomi.valkeinen@ti.com> <1321953724-6350-9-git-send-email-tomi.valkeinen@ti.com> <4ECB8D39.4000005@ti.com> <1321965130.1887.46.camel@deskari> In-Reply-To: <1321965130.1887.46.camel@deskari> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Tomi Valkeinen Cc: linux-fbdev@vger.kernel.org, linux-omap@vger.kernel.org, archit@ti.com On Tuesday 22 November 2011 06:02 PM, Tomi Valkeinen wrote: > On Tue, 2011-11-22 at 17:23 +0530, Archit Taneja wrote: >>> - r = taal_set_update_window(td, x, y, w, h); >>> + /* XXX no need to send this every frame, but dsi break if not >> done */ >>> + r = taal_set_update_window(td, 0, 0, >>> + td->panel_config->timings.x_res, >>> + td->panel_config->timings.y_res); >> >> How about sending a null short packet, and a BTA after that. This >> will >> keep automatic TE mode in place, and we'll need to send 1 short >> packet >> instead of 2 long packets every frame. > > To be honest, I didn't spend any time with this. True, sending a null > packet and BTA instead of the 2 long packets is possible. But probably > even better would be to track the TE status, and send a BTA only when > needed. Right, if we maintain the TE status, we may not need to send a packet at all, so I guess we could stick with this for now, and remove it once we start maintaining the number of BTAs we have sent to the panel. Archit > > Tomi >