From: Timur Tabi <timur@freescale.com>
To: linux-fbdev@vger.kernel.org
Subject: Re: Should I use FBINFO_VIRTFB?
Date: Thu, 15 Dec 2011 22:10:42 +0000 [thread overview]
Message-ID: <4EEA7062.9050807@freescale.com> (raw)
In-Reply-To: <4EEA5DA7.3010406@freescale.com>
Konrad Rzeszutek Wilk wrote:
>> > #define FBINFO_PARTIAL_PAN_OK 0x0040 /* otw use pan only for double-buffering */
>> > #define FBINFO_READS_FAST 0x0080 /* soft-copy faster than rendering */
> Not really. They have a different function, but you are better of looking in the code
> to see how they are used.
Well, I tried that, which is why I said, "I don't see any good documentation." FBINFO_PARTIAL_PAN_OK appears to be only used in one place:
case SCROLL_PAN_REDRAW:
if ((p->yscroll + count < 2 * (p->vrows - vc->vc_rows))
&& ((!scroll_partial && (b - t = vc->vc_rows))
|| (scroll_partial
&& (b - t - count >
3 * vc->vc_rows >> 2)))) {
if (t > 0)
fbcon_redraw_move(vc, p, 0, t, count);
ypan_up_redraw(vc, t, count);
if (vc->vc_rows - b > 0)
fbcon_redraw_move(vc, p, b,
vc->vc_rows - b, b);
} else
fbcon_redraw_move(vc, p, t + count, b - t - count, t);
fbcon_clear(vc, b - count, 0, count, vc->vc_cols);
break;
I can't parse this, and I can't figure out if my driver is better off with or without FBINFO_PARTIAL_PAN_OK.
I have the same problem with FBINFO_READS_FAST.
So I really would like someone explain these macros to me.
--
Timur Tabi
Linux kernel developer at Freescale
next prev parent reply other threads:[~2011-12-15 22:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-15 20:50 Should I use FBINFO_VIRTFB? Timur Tabi
2011-12-15 21:13 ` Konrad Rzeszutek Wilk
2011-12-15 22:10 ` Timur Tabi [this message]
2011-12-16 11:53 ` Geert Uytterhoeven
2011-12-16 18:18 ` Timur Tabi
2011-12-16 20:16 ` Geert Uytterhoeven
2011-12-19 16:08 ` Timur Tabi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EEA7062.9050807@freescale.com \
--to=timur@freescale.com \
--cc=linux-fbdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).