From: Archit <a0393947@ti.com>
To: Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: linux-omap@vger.kernel.org, linux-fbdev@vger.kernel.org,
archit@ti.com, rob@ti.com
Subject: Re: [PATCH 5/6] OMAPDSS: DISPC: move fifo threhold calc to dispc.c
Date: Fri, 13 Jan 2012 20:12:58 +0000 [thread overview]
Message-ID: <4F108D7A.4010802@ti.com> (raw)
In-Reply-To: <1326455193-19716-6-git-send-email-tomi.valkeinen@ti.com>
Hi,
On Friday 13 January 2012 05:16 PM, Tomi Valkeinen wrote:
> Move fifo threshold calculation into dispc.c, as the thresholds are
> really dispc internal thing.
>
> Signed-off-by: Tomi Valkeinen<tomi.valkeinen@ti.com>
<snip>
> diff --git a/drivers/video/omap2/dss/dsi.c b/drivers/video/omap2/dss/dsi.c
> index 511ae2a..1cbb7a5 100644
> --- a/drivers/video/omap2/dss/dsi.c
> +++ b/drivers/video/omap2/dss/dsi.c
> @@ -4524,14 +4524,6 @@ int omapdss_dsi_enable_te(struct omap_dss_device *dssdev, bool enable)
> }
> EXPORT_SYMBOL(omapdss_dsi_enable_te);
>
> -void dsi_get_overlay_fifo_thresholds(enum omap_plane plane,
> - u32 fifo_size, u32 burst_size,
> - u32 *fifo_low, u32 *fifo_high)
> -{
> - *fifo_high = fifo_size - burst_size;
> - *fifo_low = fifo_size - burst_size * 2;
> -}
We are removing the special treatment for overlays connected to DSI done
before. Won't this cause the issues you saw with DSI in OMAP3?
Archit
> -
> int dsi_init_display(struct omap_dss_device *dssdev)
> {
> struct platform_device *dsidev = dsi_get_dsidev_from_dssdev(dssdev);
> diff --git a/drivers/video/omap2/dss/dss.h b/drivers/video/omap2/dss/dss.h
> index 3cf99a9..f2378a8 100644
> --- a/drivers/video/omap2/dss/dss.h
> +++ b/drivers/video/omap2/dss/dss.h
> @@ -202,9 +202,6 @@ void dss_uninit_device(struct platform_device *pdev,
> struct omap_dss_device *dssdev);
> bool dss_use_replication(struct omap_dss_device *dssdev,
> enum omap_color_mode mode);
> -void default_get_overlay_fifo_thresholds(enum omap_plane plane,
> - u32 fifo_size, u32 burst_size,
> - u32 *fifo_low, u32 *fifo_high);
>
> /* manager */
> int dss_init_overlay_managers(struct platform_device *pdev);
> @@ -313,9 +310,6 @@ int dsi_pll_calc_clock_div_pck(struct platform_device *dsidev, bool is_tft,
> int dsi_pll_init(struct platform_device *dsidev, bool enable_hsclk,
> bool enable_hsdiv);
> void dsi_pll_uninit(struct platform_device *dsidev, bool disconnect_lanes);
> -void dsi_get_overlay_fifo_thresholds(enum omap_plane plane,
> - u32 fifo_size, u32 burst_size,
> - u32 *fifo_low, u32 *fifo_high);
> void dsi_wait_pll_hsdiv_dispc_active(struct platform_device *dsidev);
> void dsi_wait_pll_hsdiv_dsi_active(struct platform_device *dsidev);
> struct platform_device *dsi_get_dsidev_from_id(int module);
> @@ -429,8 +423,8 @@ int dispc_calc_clock_rates(unsigned long dispc_fclk_rate,
>
>
> void dispc_ovl_set_fifo_threshold(enum omap_plane plane, u32 low, u32 high);
> -u32 dispc_ovl_get_fifo_size(enum omap_plane plane);
> -u32 dispc_ovl_get_burst_size(enum omap_plane plane);
> +void dispc_ovl_compute_fifo_thresholds(enum omap_plane plane,
> + u32 *fifo_low, u32 *fifo_high, bool use_fifomerge);
> int dispc_ovl_setup(enum omap_plane plane, struct omap_overlay_info *oi,
> bool ilace, bool replication);
> int dispc_ovl_enable(enum omap_plane plane, bool enable);
next prev parent reply other threads:[~2012-01-13 20:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-13 11:46 [PATCH 0/6] OMAPDSS: naive fifomerge support Tomi Valkeinen
2012-01-13 11:46 ` [PATCH 1/6] OMAPDSS: FEAT: Add FIFO_MERGE feature Tomi Valkeinen
2012-01-13 11:46 ` [PATCH 2/6] OMAPDSS: APPLY: add fifo merge support funcs Tomi Valkeinen
2012-01-13 11:46 ` [PATCH 3/6] OMAPDSS: APPLY: add fifo-merge support Tomi Valkeinen
2012-01-13 11:46 ` [PATCH 4/6] OMAPDSS: DISPC: print fifo threshold values in bytes Tomi Valkeinen
2012-01-13 11:46 ` [PATCH 5/6] OMAPDSS: DISPC: move fifo threhold calc to dispc.c Tomi Valkeinen
2012-01-13 20:12 ` Archit [this message]
2012-01-16 9:57 ` Tomi Valkeinen
2012-01-16 10:11 ` Archit
2012-01-18 8:10 ` Tomi Valkeinen
2012-01-13 11:46 ` [PATCH 6/6] OMAPDSS: DISPC: Add naive threshold calc for fifomerge Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F108D7A.4010802@ti.com \
--to=a0393947@ti.com \
--cc=archit@ti.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=rob@ti.com \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).