From: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
To: linux-fbdev@vger.kernel.org
Subject: Re: [patch v2] intelfb: remove some dead code
Date: Mon, 30 Jan 2012 05:25:04 +0000 [thread overview]
Message-ID: <4F2629B0.1020904@gmx.de> (raw)
In-Reply-To: <20120127125833.GD3356@mwanda>
On 01/27/2012 12:58 PM, Dan Carpenter wrote:
> The goto on the line before means the return is unreachable. The goto
> also returns -ENODEV so no changes are needed there.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied.
Thanks,
Florian Tobias Schandinat
> ---
> v2: fixed a typo in the commit message
>
> diff --git a/drivers/video/intelfb/intelfbdrv.c b/drivers/video/intelfb/intelfbdrv.c
> index c6afa33..02fd226 100644
> --- a/drivers/video/intelfb/intelfbdrv.c
> +++ b/drivers/video/intelfb/intelfbdrv.c
> @@ -529,7 +529,6 @@ static int __devinit intelfb_pci_register(struct pci_dev *pdev,
> if (fb_alloc_cmap(&info->cmap, 256, 1) < 0) {
> ERR_MSG("Could not allocate cmap for intelfb_info.\n");
> goto err_out_cmap;
> - return -ENODEV;
> }
>
> dinfo = info->par;
>
prev parent reply other threads:[~2012-01-30 5:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-27 12:58 [patch v2] intelfb: remove some dead code Dan Carpenter
2012-01-30 5:25 ` Florian Tobias Schandinat [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F2629B0.1020904@gmx.de \
--to=florianschandinat@gmx.de \
--cc=linux-fbdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).