From mboxrd@z Thu Jan 1 00:00:00 1970 From: Florian Tobias Schandinat Date: Mon, 13 Feb 2012 21:26:30 +0000 Subject: Re: [PATCH 13/16] riva/fbdev: fix several -Wuninitialized Message-Id: <4F398006.6080000@gmx.de> List-Id: References: <1327960820-11867-1-git-send-email-danny.kukawka@bisect.de> <1327960820-11867-14-git-send-email-danny.kukawka@bisect.de> In-Reply-To: <1327960820-11867-14-git-send-email-danny.kukawka@bisect.de> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Danny Kukawka Cc: Antonino Daplas , linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org On 01/30/2012 10:00 PM, Danny Kukawka wrote: > Fix several -Wuninitialized compiler warnings by changing the > order of getting modedb in riva_update_default_var() to set > first the fallback and then the prefered timing. > > Signed-off-by: Danny Kukawka Applied. Thanks, Florian Tobias Schandinat > --- > drivers/video/riva/fbdev.c | 5 ++--- > 1 files changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/video/riva/fbdev.c b/drivers/video/riva/fbdev.c > index 2f58cf9..90df1a6 100644 > --- a/drivers/video/riva/fbdev.c > +++ b/drivers/video/riva/fbdev.c > @@ -1816,6 +1816,8 @@ static void __devinit riva_update_default_var(struct fb_var_screeninfo *var, > specs->modedb, specs->modedb_len, > NULL, 8); > } else if (specs->modedb != NULL) { > + /* get first mode in database as fallback */ > + modedb = specs->modedb[0]; > /* get preferred timing */ > if (info->monspecs.misc & FB_MISC_1ST_DETAIL) { > int i; > @@ -1826,9 +1828,6 @@ static void __devinit riva_update_default_var(struct fb_var_screeninfo *var, > break; > } > } > - } else { > - /* otherwise, get first mode in database */ > - modedb = specs->modedb[0]; > } > var->bits_per_pixel = 8; > riva_update_var(var, &modedb);