[PATCH] fbdev: remove "default y" from FB_SH_MOBILE_MERAM

[PATCH] fbdev: remove "default y" from FB_SH_MOBILE_MERAM

[Kuninori Morimoto]

"default y" of FB_SH_MOBILE_MERAM was overkill option.
"depends on FB_SH_MOBILE_LCDC" is very enough here.
This patch remove it.

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
 drivers/video/Kconfig |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig
index 549b960..dfec9b7 100644
--- a/drivers/video/Kconfig
+++ b/drivers/video/Kconfig
@@ -1994,7 +1994,6 @@ config FB_SH_MOBILE_HDMI
 config FB_SH_MOBILE_MERAM
 	tristate "SuperH Mobile MERAM read ahead support for LCDC"
 	depends on FB_SH_MOBILE_LCDC
-	default y
 	---help---
 	  Enable MERAM support for the SH-Mobile LCD controller.
 
-- 
1.7.5.4

Re: [PATCH] fbdev: remove "default y" from FB_SH_MOBILE_MERAM

[Laurent Pinchart]

Hi Morimoto-san,

Thanks for the patch.

On Friday 02 March 2012 01:06:53 Kuninori Morimoto wrote:
> "default y" of FB_SH_MOBILE_MERAM was overkill option.
> "depends on FB_SH_MOBILE_LCDC" is very enough here.

Actually the sh_mobile_meram driver doesn't depend on the LCDC driver. What 
would you think about removing both the dependency and the default=y ?

> This patch remove it.
> 
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> ---
>  drivers/video/Kconfig |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig
> index 549b960..dfec9b7 100644
> --- a/drivers/video/Kconfig
> +++ b/drivers/video/Kconfig
> @@ -1994,7 +1994,6 @@ config FB_SH_MOBILE_HDMI
>  config FB_SH_MOBILE_MERAM
>  	tristate "SuperH Mobile MERAM read ahead support for LCDC"
>  	depends on FB_SH_MOBILE_LCDC
> -	default y
>  	---help---
>  	  Enable MERAM support for the SH-Mobile LCD controller.

-- 
Regards,

Laurent Pinchart

Re: [PATCH] fbdev: remove "default y" from FB_SH_MOBILE_MERAM

[Takanari Hayama]

Hi Laurent and Morimoto-san,

On 3/6/12 12:11 AM, Laurent Pinchart wrote:
> On Friday 02 March 2012 01:06:53 Kuninori Morimoto wrote:
>> "default y" of FB_SH_MOBILE_MERAM was overkill option.
>> "depends on FB_SH_MOBILE_LCDC" is very enough here.
> 
> Actually the sh_mobile_meram driver doesn't depend on the LCDC driver. What 
> would you think about removing both the dependency and the default=y ?

I agree with Laurent here. MERAM can be used for other IP blocks as well
in the future, e.g. the CEU driver. The LCDC was the only driver using
it, but doesn't necessarily mean that the MERAM driver depends on the
LCDC. In some case, you might even want to disable MERAM for the LCDC if
there's not enough memory on MERAM.

> 
>> This patch remove it.
>>
>> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
>> ---
>>  drivers/video/Kconfig |    1 -
>>  1 files changed, 0 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig
>> index 549b960..dfec9b7 100644
>> --- a/drivers/video/Kconfig
>> +++ b/drivers/video/Kconfig
>> @@ -1994,7 +1994,6 @@ config FB_SH_MOBILE_HDMI
>>  config FB_SH_MOBILE_MERAM
>>  	tristate "SuperH Mobile MERAM read ahead support for LCDC"
>>  	depends on FB_SH_MOBILE_LCDC
>> -	default y
>>  	---help---
>>  	  Enable MERAM support for the SH-Mobile LCD controller.
> 

Takanari Hayama, Ph.D. (taki@igel.co.jp)
IGEL Co.,Ltd.
http://www.igel.co.jp/

Re: [PATCH] fbdev: remove "default y" from FB_SH_MOBILE_MERAM

[Kuninori Morimoto]

Hi Laurent, Hayama-san

Thank you for your advice

> > On Friday 02 March 2012 01:06:53 Kuninori Morimoto wrote:
> >> "default y" of FB_SH_MOBILE_MERAM was overkill option.
> >> "depends on FB_SH_MOBILE_LCDC" is very enough here.
> > 
> > Actually the sh_mobile_meram driver doesn't depend on the LCDC driver. What 
> > would you think about removing both the dependency and the default=y ?
> 
> I agree with Laurent here. MERAM can be used for other IP blocks as well
> in the future, e.g. the CEU driver. The LCDC was the only driver using
> it, but doesn't necessarily mean that the MERAM driver depends on the
> LCDC. In some case, you might even want to disable MERAM for the LCDC if
> there's not enough memory on MERAM.

Thanks.
I send v2 patch.


Best regards
---
Kuninori Morimoto