From mboxrd@z Thu Jan 1 00:00:00 1970 From: "H. Peter Anvin" Date: Wed, 14 Mar 2012 00:43:25 +0000 Subject: Re: [PATCH] x86: export 'pcibios_enabled' Message-Id: <4F5FE9AD.7000204@zytor.com> List-Id: References: <20120313204114.e160849af7dbe5a4b4e5c0ad@canb.auug.org.au> <4F5FAE63.3090908@xenotime.net> In-Reply-To: <4F5FAE63.3090908@xenotime.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Randy Dunlap Cc: Stephen Rothwell , linux-next@vger.kernel.org, LKML , Michal Januszewski , Florian Tobias Schandinat , linux-fbdev@vger.kernel.org, x86@kernel.org, Andrew Morton On 03/13/2012 01:30 PM, Randy Dunlap wrote: > From: Randy Dunlap > > Export 'pcibios_enabled' so that when uvesafb is built as a > loadable module (on X86_32), the build will succeed. > > ERROR: "pcibios_enabled" [drivers/video/uvesafb.ko] undefined! > > Signed-off-by: Randy Dunlap > Cc: Michal Januszewski > Cc: Florian Tobias Schandinat > Cc: linux-fbdev@vger.kernel.org > Cc: x86@kernel.org > --- > Applies to mainline; found in linux-next. > > arch/x86/pci/pcbios.c | 1 + > 1 file changed, 1 insertion(+) > > --- linux-next-20120313.orig/arch/x86/pci/pcbios.c > +++ linux-next-20120313/arch/x86/pci/pcbios.c > @@ -27,6 +27,7 @@ > #define PCIBIOS_HW_TYPE2_SPEC 0x20 > > int pcibios_enabled; > +EXPORT_SYMBOL(pcibios_enabled); > > /* According to the BIOS specification at: > * http://members.datafast.net.au/dft0802/specs/bios21.pdf, we could I would think this should be EXPORT_SYMBOL_GPL()... this seems like a symbol with a very high likelihood to be abused in strange ways. -hpa