* [PATCH 1/7] drivers/video/pvr2fb.c: ensure arguments to request_irq and free_irq are compatible [not found] <1331494587-12196-1-git-send-email-Julia.Lawall@lip6.fr> @ 2012-03-11 19:36 ` Julia Lawall 2012-03-21 18:37 ` Florian Tobias Schandinat 0 siblings, 1 reply; 2+ messages in thread From: Julia Lawall @ 2012-03-11 19:36 UTC (permalink / raw) To: Florian Tobias Schandinat; +Cc: kernel-janitors, linux-fbdev, linux-kernel From: Julia Lawall <Julia.Lawall@lip6.fr> Convert calls to free_irq so that the second argument is the same as the last argument of the corresponding call to request_irq. Without this property, free_irq does nothing. Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> --- Not tested. drivers/video/pvr2fb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/video/pvr2fb.c b/drivers/video/pvr2fb.c index 3a3fdc6..bcd44c3 100644 --- a/drivers/video/pvr2fb.c +++ b/drivers/video/pvr2fb.c @@ -895,7 +895,7 @@ static int __init pvr2fb_dc_init(void) #ifdef CONFIG_PVR2_DMA if (request_dma(pvr2dma, "pvr2") != 0) { - free_irq(HW_EVENT_VSYNC, 0); + free_irq(HW_EVENT_VSYNC, fb_info); return -EBUSY; } #endif @@ -914,7 +914,7 @@ static void __exit pvr2fb_dc_exit(void) currentpar->mmio_base = 0; } - free_irq(HW_EVENT_VSYNC, 0); + free_irq(HW_EVENT_VSYNC, fb_info); #ifdef CONFIG_PVR2_DMA free_dma(pvr2dma); #endif ^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/7] drivers/video/pvr2fb.c: ensure arguments to request_irq and free_irq are compatible 2012-03-11 19:36 ` [PATCH 1/7] drivers/video/pvr2fb.c: ensure arguments to request_irq and free_irq are compatible Julia Lawall @ 2012-03-21 18:37 ` Florian Tobias Schandinat 0 siblings, 0 replies; 2+ messages in thread From: Florian Tobias Schandinat @ 2012-03-21 18:37 UTC (permalink / raw) To: Julia Lawall; +Cc: kernel-janitors, linux-fbdev, linux-kernel On 03/11/2012 07:36 PM, Julia Lawall wrote: > From: Julia Lawall <Julia.Lawall@lip6.fr> > > Convert calls to free_irq so that the second argument is the same as the > last argument of the corresponding call to request_irq. Without this > property, free_irq does nothing. > > Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> Applied. Thanks, Florian Tobias Schandinat > > --- > Not tested. > > drivers/video/pvr2fb.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/video/pvr2fb.c b/drivers/video/pvr2fb.c > index 3a3fdc6..bcd44c3 100644 > --- a/drivers/video/pvr2fb.c > +++ b/drivers/video/pvr2fb.c > @@ -895,7 +895,7 @@ static int __init pvr2fb_dc_init(void) > > #ifdef CONFIG_PVR2_DMA > if (request_dma(pvr2dma, "pvr2") != 0) { > - free_irq(HW_EVENT_VSYNC, 0); > + free_irq(HW_EVENT_VSYNC, fb_info); > return -EBUSY; > } > #endif > @@ -914,7 +914,7 @@ static void __exit pvr2fb_dc_exit(void) > currentpar->mmio_base = 0; > } > > - free_irq(HW_EVENT_VSYNC, 0); > + free_irq(HW_EVENT_VSYNC, fb_info); > #ifdef CONFIG_PVR2_DMA > free_dma(pvr2dma); > #endif > > ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-03-21 18:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1331494587-12196-1-git-send-email-Julia.Lawall@lip6.fr>
2012-03-11 19:36 ` [PATCH 1/7] drivers/video/pvr2fb.c: ensure arguments to request_irq and free_irq are compatible Julia Lawall
2012-03-21 18:37 ` Florian Tobias Schandinat
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).