From mboxrd@z Thu Jan 1 00:00:00 1970 From: Archit Taneja Date: Thu, 19 Apr 2012 12:10:13 +0000 Subject: Re: [PATCH 0/6] OMAPDSS: APPLY: Treat overlay manager timings as shadow registers Message-Id: <4F8FFDD5.5030302@ti.com> List-Id: References: <1334561027-28569-1-git-send-email-archit@ti.com> <1334836135.1911.40.camel@deskari> In-Reply-To: <1334836135.1911.40.camel@deskari> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Tomi Valkeinen Cc: linux-omap@vger.kernel.org, linux-fbdev@vger.kernel.org On Thursday 19 April 2012 05:18 PM, Tomi Valkeinen wrote: > On Mon, 2012-04-16 at 12:53 +0530, Archit Taneja wrote: >> An overlay manager's timings (the manager size, and blanking parameters if an >> LCD manager) are DISPC shadow registers, and they should hence follow the >> correct programming model. >> >> This set makes the timings a manager_info parameter. The interface drivers now >> set the timings in manager_info instead of directly writing to registers. >> >> This change also prevents the need to use display resolution for overlay >> checks, hence making some of the APPLY functions less dependent on the display. >> >> These patches apply over: >> >> git://gitorious.org/linux-omap-dss2/linux.git dev >> >> Archit Taneja (6): >> OMAPDSS: DISPC/RFBI: Use dispc_mgr_set_lcd_timings() for setting lcd >> size >> OMAPDSS: DISPC: Use a common function to set manager timings >> OMAPDSS: DISPC: Clean up manager timing/size functions >> OMAPDSS: MANAGER: Make DISPC timings a manager_info parameter >> OMAPDSS: MANAGER: Check validity of manager timings >> OMAPDSS: APPLY: Remove display dependency from overlay and manager >> checks > > The patches 1, 2 and 3 in this series look like independent cleanups. > Should I apply those, or do you think there may be changes required? I think you can pull these 3, they were sort of a prerequisite for the apply-manager-timings stuff. I don't think they need to change. I'll post another series for applying the manager timings correctly(i.e, the fixed version of the last 3 patches). Archit > > Tomi >