From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ryan Mallon Date: Tue, 24 Apr 2012 21:12:28 +0000 Subject: Re: [PATCH] drivers/video/ep93xx-fb.c: clean up error-handling code Message-Id: <4F97173C.5010808@gmail.com> List-Id: References: <1334777828-3557-1-git-send-email-Julia.Lawall@lip6.fr> <4F8F5938.2000207@gmail.com> <000401cd1dd2$5f8ee3b0$1eacab10$%han@samsung.com> <1335271586.25429.19.camel@joe2Laptop> In-Reply-To: <1335271586.25429.19.camel@joe2Laptop> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Joe Perches Cc: Julia Lawall , Jingoo Han , 'Florian Tobias Schandinat' , kernel-janitors@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org On 24/04/12 22:46, Joe Perches wrote: > On Thu, 2012-04-19 at 07:14 +0200, Julia Lawall wrote: >> I don't know thw impact of the ./. I use the options >> >> --nokeywords --nogit-fallback --subsystem --norolestats -f >> >> julia >> >> On Thu, 19 Apr 2012, Jingoo Han wrote: >> >>>> -----Original Message----- >>>> From: Ryan Mallon > [] >>>> Oddly, scripts/get_maintainer.pl on this file doesn't return me, even >>>> though, according to git blame, I am the author of 90% of the commits. >>>> Should I have an entry in the MAINTAINERS file, or is >>>> scripts/get_maintainer.pl not working properly? >>> >>> There are optional differences in using scripts/get_maintainer.pl. >>> If you use './' ahead of file path, you will see your name. >>> >>> Without './' ahead of 'drivers/video/ep93xx-fb.c': >>> ./scripts/get_maintainer.pl --file drivers/video/ep93xx-fb.c >>> Florian Tobias Schandinat (maintainer:FRAMEBUFFER LAYER) >>> linux-fbdev@vger.kernel.org (open list:FRAMEBUFFER LAYER) >>> linux-kernel@vger.kernel.org (open list) >>> >>> With './' ahead of 'drivers/video/ep93xx-fb.c': >>> ./scripts/get_maintainer.pl --file ./drivers/video/ep93xx-fb.c >>> Ryan Mallon (commit_signer:2/3g%) >>> Paul Gortmaker (commit_signer:1/33%) >>> H Hartley Sweeten (commit_signer:1/33%) >>> Jesper Juhl (commit_signer:1/33%) >>> Jiri Kosina (commit_signer:1/33%) >>> linux-kernel@vger.kernel.org (open list) > > Prefixing "./" to the file path bypasses the normal > get_maintainers pattern check for file maintainership. > > Florian Schandinat and linux-fbdev are not returned > in the second lookup above. > > One of the patterns for FRAMEBUFFER is > F: drivers/video/ > which is a direct match for is ep93xx-fb.c file, > so --git is not used by default. > > Adding --git may be appropriate and it also returns > Ryan's name in this case. Hi Joe, Thanks for the info. > Nominally, as framebuffer maintainer, Florian > should also have "signed-off" on these commits, > but many subsystems don't actually have a > single path or person for patches and commits. > > This file came into the tree via Andrew Morton. > The original driver was written before Florian became the framebuffer maintainer. The subsystem had no real maintainer at the time, which is why it went via Andrew. > About maintainership for individual files: > > If anyone thinks they are the maintainer for > a particular file, generally they should submit > a patch to MAINTAINERS adding a section with > their name, maintainership level and an > appropriate file pattern. Hmm, perhaps author is a better term than maintainer here. Any patches should still go via the framebuffer maintainer, Florian, but it would be useful in many cases for the original and/or most regular commit author to also get Cc'ed since in many cases they will have a better understanding of the code, even if the aren't "maintaining" it. ~Ryan