From: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
To: linux-fbdev@vger.kernel.org
Subject: Re: [PULL for v3.5] SH Mobile LCDC overlay support
Date: Sun, 13 May 2012 20:36:29 +0000 [thread overview]
Message-ID: <4FB01B4D.4060700@gmx.de> (raw)
In-Reply-To: <5022250.LOHRC1DPLO@avalon>
Hi Laurent,
On 04/24/2012 11:31 AM, Laurent Pinchart wrote:
> Hi Florian,
>
> Could you please pull the following patches that add overlay support for the
> SH Mobile LCDC ? They have been posted for review as part of a bigger series
> some time ago.
Well, besides that I dislike everyone inventing his/her own overlay API
and just not having time to propose something that fits everyone your
patch looks mostly okay. Two things:
"That's fine, but you need a Documentation/ABI entry for any new sysfs
file you create." [Greg K-H]
So as far as I understand Gregs statement and your code correct you
should add such thing.
I'm not convinced that you don't leak resources. Is the memory you
allocate with dma_alloc_coherent for the overlays really freed after
normal use and in error paths?
Best regards,
Florian Tobias Schandinat
>
> The following changes since commit d313a86d2efb2c5568832389663322e93e291c59:
>
> i.MX28: Shut down the LCD controller to avoid BootROM sampling bug
> (2012-04-21 21:53:12 +0000)
>
> are available in the git repository at:
> git://linuxtv.org/pinchartl/fbdev.git planes
>
> Laurent Pinchart (3):
> fbdev: sh_mobile_lcdc: Constify sh_mobile_lcdc_fix structure
> fbdev: sh_mobile_lcdc: Rename fb operation handlers with a common prefix
> fbdev: sh_mobile_lcdc: Implement overlays support
>
> drivers/video/sh_mobile_lcdcfb.c | 1004 +++++++++++++++++++++++++++++++++----
> include/video/sh_mobile_lcdc.h | 7 +
> 2 files changed, 915 insertions(+), 96 deletions(-)
>
next prev parent reply other threads:[~2012-05-13 20:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-24 11:31 [PULL for v3.5] SH Mobile LCDC overlay support Laurent Pinchart
2012-05-13 20:36 ` Florian Tobias Schandinat [this message]
2012-05-15 19:19 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FB01B4D.4060700@gmx.de \
--to=florianschandinat@gmx.de \
--cc=linux-fbdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).