linux-fbdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] drivers/video/intelfb/intelfbdrv.c: add missing agp_backend_release
@ 2012-04-19 16:55 Julia Lawall
  2012-05-13 20:50 ` Florian Tobias Schandinat
  0 siblings, 1 reply; 2+ messages in thread
From: Julia Lawall @ 2012-04-19 16:55 UTC (permalink / raw)
  To: Maik Broemme
  Cc: kernel-janitors, Florian Tobias Schandinat, linux-fbdev,
	linux-kernel

From: Julia Lawall <Julia.Lawall@lip6.fr>

Release bridge, as done on all other paths out of the function.

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>

---
 drivers/video/intelfb/intelfbdrv.c |    2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/video/intelfb/intelfbdrv.c b/drivers/video/intelfb/intelfbdrv.c
index 02fd226..bdcbfba 100644
--- a/drivers/video/intelfb/intelfbdrv.c
+++ b/drivers/video/intelfb/intelfbdrv.c
@@ -680,6 +680,7 @@ static int __devinit intelfb_pci_register(struct pci_dev *pdev,
 		 + dinfo->fb.size);
 	if (!dinfo->aperture.virtual) {
 		ERR_MSG("Cannot remap FB region.\n");
+		agp_backend_release(bridge);
 		cleanup(dinfo);
 		return -ENODEV;
 	}
@@ -689,6 +690,7 @@ static int __devinit intelfb_pci_register(struct pci_dev *pdev,
 					      INTEL_REG_SIZE);
 	if (!dinfo->mmio_base) {
 		ERR_MSG("Cannot remap MMIO region.\n");
+		agp_backend_release(bridge);
 		cleanup(dinfo);
 		return -ENODEV;
 	}


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] drivers/video/intelfb/intelfbdrv.c: add missing agp_backend_release
  2012-04-19 16:55 [PATCH] drivers/video/intelfb/intelfbdrv.c: add missing agp_backend_release Julia Lawall
@ 2012-05-13 20:50 ` Florian Tobias Schandinat
  0 siblings, 0 replies; 2+ messages in thread
From: Florian Tobias Schandinat @ 2012-05-13 20:50 UTC (permalink / raw)
  To: Julia Lawall; +Cc: Maik Broemme, kernel-janitors, linux-fbdev, linux-kernel

On 04/19/2012 04:55 PM, Julia Lawall wrote:
> From: Julia Lawall <Julia.Lawall@lip6.fr>
> 
> Release bridge, as done on all other paths out of the function.
> 
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>

Looks good to me, applied.


Thanks,

Florian Tobias Schandinat

> 
> ---
>  drivers/video/intelfb/intelfbdrv.c |    2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/video/intelfb/intelfbdrv.c b/drivers/video/intelfb/intelfbdrv.c
> index 02fd226..bdcbfba 100644
> --- a/drivers/video/intelfb/intelfbdrv.c
> +++ b/drivers/video/intelfb/intelfbdrv.c
> @@ -680,6 +680,7 @@ static int __devinit intelfb_pci_register(struct pci_dev *pdev,
>  		 + dinfo->fb.size);
>  	if (!dinfo->aperture.virtual) {
>  		ERR_MSG("Cannot remap FB region.\n");
> +		agp_backend_release(bridge);
>  		cleanup(dinfo);
>  		return -ENODEV;
>  	}
> @@ -689,6 +690,7 @@ static int __devinit intelfb_pci_register(struct pci_dev *pdev,
>  					      INTEL_REG_SIZE);
>  	if (!dinfo->mmio_base) {
>  		ERR_MSG("Cannot remap MMIO region.\n");
> +		agp_backend_release(bridge);
>  		cleanup(dinfo);
>  		return -ENODEV;
>  	}
> 
> 


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-05-13 20:50 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-04-19 16:55 [PATCH] drivers/video/intelfb/intelfbdrv.c: add missing agp_backend_release Julia Lawall
2012-05-13 20:50 ` Florian Tobias Schandinat

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).