From: Dan Carpenter <dan.carpenter@linaro.org>
To: Andy Shevchenko <andriy.shevchenko@intel.com>
Cc: Abdun Nihaal <abdun.nihaal@gmail.com>,
andy@kernel.org, gregkh@linuxfoundation.org,
lorenzo.stoakes@oracle.com, tzimmermann@suse.de,
riyandhiman14@gmail.com, willy@infradead.org, notro@tronnes.org,
thomas.petazzoni@free-electrons.com,
dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 1/2] Revert "staging: fbtft: fix potential memory leak in fbtft_framebuffer_alloc()"
Date: Tue, 1 Jul 2025 17:16:07 +0300 [thread overview]
Message-ID: <4c1aa07f-082a-4ba0-ad3e-14eba02423f2@suswa.mountain> (raw)
In-Reply-To: <aGPnPVjB6bGKMkwV@smile.fi.intel.com>
On Tue, Jul 01, 2025 at 04:48:45PM +0300, Andy Shevchenko wrote:
> On Tue, Jul 01, 2025 at 03:10:22PM +0530, Abdun Nihaal wrote:
> > This reverts commit eb2cb7dab60f ("staging: fbtft: fix potential memory
> > leak in fbtft_framebuffer_alloc()").
> >
> > An updated patch has been added as commit 505bffe21233 ("staging:
> > fbtft: fix potential memory leak in fbtft_framebuffer_alloc()"),
> > and so reverting the old patch.
>
> Revert has its automatic line, please do not remove it.
Why?
I hate the revert format. It is from when git was invented in 2005.
It sets you up for failure. These days we have so many other things
that we want in patches.
1) The subsystem prefix in the subject
2) The 12 character hashes
3) A proper commit message
4) A Fixes tag
The automated revert commit messages don't have any of that. It's
always better to hand write them.
regards,
dan carpenter
next prev parent reply other threads:[~2025-07-01 14:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-01 9:40 [PATCH v4 0/2] staging: fbtft: cleanup fbtft_framebuffer_alloc() Abdun Nihaal
2025-07-01 9:40 ` [PATCH v4 1/2] Revert "staging: fbtft: fix potential memory leak in fbtft_framebuffer_alloc()" Abdun Nihaal
2025-07-01 13:48 ` Andy Shevchenko
2025-07-01 14:16 ` Dan Carpenter [this message]
2025-07-01 14:19 ` Greg KH
2025-07-01 14:13 ` Dan Carpenter
2025-07-01 9:40 ` [PATCH v4 2/2] staging: fbtft: cleanup error handling in fbtft_framebuffer_alloc() Abdun Nihaal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4c1aa07f-082a-4ba0-ad3e-14eba02423f2@suswa.mountain \
--to=dan.carpenter@linaro.org \
--cc=abdun.nihaal@gmail.com \
--cc=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=lorenzo.stoakes@oracle.com \
--cc=notro@tronnes.org \
--cc=riyandhiman14@gmail.com \
--cc=thomas.petazzoni@free-electrons.com \
--cc=tzimmermann@suse.de \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox