From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mout.gmx.net (mout.gmx.net [212.227.15.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2C4B71A7067; Wed, 28 Aug 2024 18:09:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=212.227.15.19 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724868543; cv=none; b=itZRt5U4Bj0PtQ0t7kXJKD4UU/yWk1ovnCfllyRjVe582sOccFqLYRxRrNHSUrunH6MIP6WsDBPB691jYmxQVIYcea+i9fKj0dIAH35Fle8VGgsqlVg74/HbqunrfB5w55jG1eUgcj7YbdDoOJ+vAlyCWVUU2twQTVWGIxM5inM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724868543; c=relaxed/simple; bh=yB6uZukIwE+X4offf/wIBMkWmN7C3qjKU4UzOvr7GJo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=HNaghOeoLwuZb3fQtL8J31cJarfdQpn3kcTcos9CcxHPdgDmRqr0lEYjflpc4isMZ5iHEj2/0duunqzw5LqHjYliVGXNDUvDAaVR6V4VQT9gjWt0KK4QDF+fVZ1jmXTZLediYeU4Xp/zg7vLpVJFomwQ/5UgKJZX9orQcfZKdmQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.de; spf=pass smtp.mailfrom=gmx.de; dkim=pass (2048-bit key) header.d=gmx.de header.i=deller@gmx.de header.b=Pb5ORQCf; arc=none smtp.client-ip=212.227.15.19 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmx.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmx.de header.i=deller@gmx.de header.b="Pb5ORQCf" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.de; s=s31663417; t=1724868536; x=1725473336; i=deller@gmx.de; bh=Xix/dBO1oukhRqWBWYAXqCl/z3ryffHxBzJU1L/ZpLw=; h=X-UI-Sender-Class:Message-ID:Date:MIME-Version:Subject:To:Cc: References:From:In-Reply-To:Content-Type: Content-Transfer-Encoding:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=Pb5ORQCfpoHGjwETSjKy3kBzhxaaHfpwubFjgV03f8rq2IWWCDw22QLMIlnPQbEa HUL6TqoGESdvXGR0JwBozMWK7fjdKxUBNkqTag+KjqWbGeS+7g6LJ60nZ9mg1XHpi WTqQrqnxZ53vY0eXDHcgFxIsVO8LFoN6JQlmAioSm5VPrNEd3LeZwaYmnZT6K1ybF ouIUPrvUIULgBQKGUhKM7voU8Bs4XNMefLuOPltpP9SghpZpLiHsxrDmw38QsfMeQ g/lQ9ruvhytla/X48cl4eJOCn6lb3au+KuPNpS+6PasqyShhj370rzmD0EShDrGm2 ZNza+qMvHjSNuuB6UA== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from [192.168.20.55] ([109.250.63.126]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MIMbO-1svRuO2Qei-00DlMr; Wed, 28 Aug 2024 20:08:56 +0200 Message-ID: <4ce943f8-9557-4563-a107-acb78a0b33f5@gmx.de> Date: Wed, 28 Aug 2024 20:08:55 +0200 Precedence: bulk X-Mailing-List: linux-fbdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] fbdev: omapfb: panel-sony-acx565akm: Simplify show_cabc_available_modes() To: Christophe JAILLET Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-omap@vger.kernel.org, linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org References: <91fc9049558a4865d441930c8f4732461f478eca.1723110340.git.christophe.jaillet@wanadoo.fr> Content-Language: en-US From: Helge Deller Autocrypt: addr=deller@gmx.de; keydata= xsFNBF3Ia3MBEAD3nmWzMgQByYAWnb9cNqspnkb2GLVKzhoH2QD4eRpyDLA/3smlClbeKkWT HLnjgkbPFDmcmCz5V0Wv1mKYRClAHPCIBIJgyICqqUZo2qGmKstUx3pFAiztlXBANpRECgwJ r+8w6mkccOM9GhoPU0vMaD/UVJcJQzvrxVHO8EHS36aUkjKd6cOpdVbCt3qx8cEhCmaFEO6u CL+k5AZQoABbFQEBocZE1/lSYzaHkcHrjn4cQjc3CffXnUVYwlo8EYOtAHgMDC39s9a7S90L 69l6G73lYBD/Br5lnDPlG6dKfGFZZpQ1h8/x+Qz366Ojfq9MuuRJg7ZQpe6foiOtqwKym/zV dVvSdOOc5sHSpfwu5+BVAAyBd6hw4NddlAQUjHSRs3zJ9OfrEx2d3mIfXZ7+pMhZ7qX0Axlq Lq+B5cfLpzkPAgKn11tfXFxP+hcPHIts0bnDz4EEp+HraW+oRCH2m57Y9zhcJTOJaLw4YpTY GRUlF076vZ2Hz/xMEvIJddRGId7UXZgH9a32NDf+BUjWEZvFt1wFSW1r7zb7oGCwZMy2LI/G aHQv/N0NeFMd28z+deyxd0k1CGefHJuJcOJDVtcE1rGQ43aDhWSpXvXKDj42vFD2We6uIo9D 1VNre2+uAxFzqqf026H6cH8hin9Vnx7p3uq3Dka/Y/qmRFnKVQARAQABzRxIZWxnZSBEZWxs ZXIgPGRlbGxlckBnbXguZGU+wsGRBBMBCAA7AhsDBQsJCAcCBhUKCQgLAgQWAgMBAh4BAheA FiEERUSCKCzZENvvPSX4Pl89BKeiRgMFAl3J1zsCGQEACgkQPl89BKeiRgNK7xAAg6kJTPje uBm9PJTUxXaoaLJFXbYdSPfXhqX/BI9Xi2VzhwC2nSmizdFbeobQBTtRIz5LPhjk95t11q0s uP5htzNISPpwxiYZGKrNnXfcPlziI2bUtlz4ke34cLK6MIl1kbS0/kJBxhiXyvyTWk2JmkMi REjR84lCMAoJd1OM9XGFOg94BT5aLlEKFcld9qj7B4UFpma8RbRUpUWdo0omAEgrnhaKJwV8 qt0ULaF/kyP5qbI8iA2PAvIjq73dA4LNKdMFPG7Rw8yITQ1Vi0DlDgDT2RLvKxEQC0o3C6O4 iQq7qamsThLK0JSDRdLDnq6Phv+Yahd7sDMYuk3gIdoyczRkXzncWAYq7XTWl7nZYBVXG1D8 gkdclsnHzEKpTQIzn/rGyZshsjL4pxVUIpw/vdfx8oNRLKj7iduf11g2kFP71e9v2PP94ik3 Xi9oszP+fP770J0B8QM8w745BrcQm41SsILjArK+5mMHrYhM4ZFN7aipK3UXDNs3vjN+t0zi qErzlrxXtsX4J6nqjs/mF9frVkpv7OTAzj7pjFHv0Bu8pRm4AyW6Y5/H6jOup6nkJdP/AFDu 5ImdlA0jhr3iLk9s9WnjBUHyMYu+HD7qR3yhX6uWxg2oB2FWVMRLXbPEt2hRGq09rVQS7DBy dbZgPwou7pD8MTfQhGmDJFKm2jvOwU0EXchrcwEQAOsDQjdtPeaRt8EP2pc8tG+g9eiiX9Sh rX87SLSeKF6uHpEJ3VbhafIU6A7hy7RcIJnQz0hEUdXjH774B8YD3JKnAtfAyuIU2/rOGa/v UN4BY6U6TVIOv9piVQByBthGQh4YHhePSKtPzK9Pv/6rd8H3IWnJK/dXiUDQllkedrENXrZp eLUjhyp94ooo9XqRl44YqlsrSUh+BzW7wqwfmu26UjmAzIZYVCPCq5IjD96QrhLf6naY6En3 ++tqCAWPkqKvWfRdXPOz4GK08uhcBp3jZHTVkcbo5qahVpv8Y8mzOvSIAxnIjb+cklVxjyY9 dVlrhfKiK5L+zA2fWUreVBqLs1SjfHm5OGuQ2qqzVcMYJGH/uisJn22VXB1c48yYyGv2HUN5 lC1JHQUV9734I5cczA2Gfo27nTHy3zANj4hy+s/q1adzvn7hMokU7OehwKrNXafFfwWVK3OG 1dSjWtgIv5KJi1XZk5TV6JlPZSqj4D8pUwIx3KSp0cD7xTEZATRfc47Yc+cyKcXG034tNEAc xZNTR1kMi9njdxc1wzM9T6pspTtA0vuD3ee94Dg+nDrH1As24uwfFLguiILPzpl0kLaPYYgB wumlL2nGcB6RVRRFMiAS5uOTEk+sJ/tRiQwO3K8vmaECaNJRfJC7weH+jww1Dzo0f1TP6rUa fTBRABEBAAHCwXYEGAEIACAWIQRFRIIoLNkQ2+89Jfg+Xz0Ep6JGAwUCXchrcwIbDAAKCRA+ Xz0Ep6JGAxtdEAC54NQMBwjUNqBNCMsh6WrwQwbg9tkJw718QHPw43gKFSxFIYzdBzD/YMPH l+2fFiefvmI4uNDjlyCITGSM+T6b8cA7YAKvZhzJyJSS7pRzsIKGjhk7zADL1+PJei9p9idy RbmFKo0dAL+ac0t/EZULHGPuIiavWLgwYLVoUEBwz86ZtEtVmDmEsj8ryWw75ZIarNDhV74s BdM2ffUJk3+vWe25BPcJiaZkTuFt+xt2CdbvpZv3IPrEkp9GAKof2hHdFCRKMtgxBo8Kao6p Ws/Vv68FusAi94ySuZT3fp1xGWWf5+1jX4ylC//w0Rj85QihTpA2MylORUNFvH0MRJx4mlFk XN6G+5jIIJhG46LUucQ28+VyEDNcGL3tarnkw8ngEhAbnvMJ2RTx8vGh7PssKaGzAUmNNZiG MB4mPKqvDZ02j1wp7vthQcOEg08z1+XHXb8ZZKST7yTVa5P89JymGE8CBGdQaAXnqYK3/yWf FwRDcGV6nxanxZGKEkSHHOm8jHwvQWvPP73pvuPBEPtKGLzbgd7OOcGZWtq2hNC6cRtsRdDx 4TAGMCz4j238m+2mdbdhRh3iBnWT5yPFfnv/2IjFAk+sdix1Mrr+LIDF++kiekeq0yUpDdc4 ExBy2xf6dd+tuFFBp3/VDN4U0UfG4QJ2fg19zE5Z8dS4jGIbLg== In-Reply-To: <91fc9049558a4865d441930c8f4732461f478eca.1723110340.git.christophe.jaillet@wanadoo.fr> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:awWueHYvHTlFQIUT4Nu+e4FKf89XTtu5qyRcGOdQ0wYYywk5ejL 0d3fBMft/5HXbGHpwVImbA8ZZZfLRcp5GN+bn+P96Y6yYJUWih6R/8/d5hyJnQI0QCrdwQh Lez8+WlDT/iZsKq5RkYl8ngIR7SOzrCKcXs5SI47wDxVtP3NVnBDYjpT7THm0udIcx6urQh MtdfQJsarn2cElrR6fZog== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:hbaTjg7ikic=;KYDk9hSyEvA1QJEeWfGb+BbKS3a CS1zDHqMALNKRd5mVzrlyPR7D4wc6+H1LQjbswfZyy2P5q8YRQtIfp8HZF6+UuQgdRCSyFZLm 7cnZHOSNHoC/EVdpwJPfaopfdtqKX/odsaGWl1Z3thC9KQ0W6NZ3mT5xSinyDEncpUXZDhVry AfVEDE5IO/bBI9nCa1qvIheXJWQq+PKXymCK2symhJ3/71i6sbv2sw1gPLSC6GHySuCsEbxzW Aa5l4JsVR3PKjN/vstWwYvGNLpFAJ3TTwDVyMksUyTndwALXSKhEAwrMC8k4jLsDbfaCv5sMo BRxmibncUZI0IAXIbhSaysFh5bHWxo94cA2aLyfmRtKKV6RN65bH8ol0G0ETMZn77bM/MUPJG WhqZ6r5j+gkpbTv7P0jfk7OUveSjt1kM85BXbxYR8xFDdg+0bwMp6RlqypzFrPpo8s5dj9mVJ pffZBnoNlixrKljrzE0pFhIb9TDMHoj+xgxMFFuSuDOGx0dNyo+OjHu0YBdj9YeQv/y8WS5V7 TM95214z+T5eq25EbvZjUn7TSWHRQTntue+svX6JPu4H138/IKNMOhGmejo6qgaEXN7wuECAG 2Hc2yLRRGrEwfgQG/du9G0RGkDt2EzyyRacAK6xR1fbEHxlEJqHNjGpJe8qdr7wmRZjoULKgj nq4kWxeqXPeGzU7UUzvpm17kdpuZtlIgwe7Qxiq3M7EWFSNHxxp4lJecddD5KwJpEYmmPOrUF 4uQeOKZBiuZoPTPUxkeUeoDaJkk5MJQmaKHnQ6AMbDWVA9N+NY1awC1biPrVHugnWwl1oeKQv J4QnWT6R6PVF6Kvevpkr55Nw== On 8/8/24 11:46, Christophe JAILLET wrote: > Use sysfs_emit_at() instead of snprintf() + custom logic. > Using sysfs_emit_at() is much more simple. > > Also, sysfs_emit() is already used in this function, so using > sysfs_emit_at() is more consistent. > > Also simplify the logic: > - always add a space after an entry > - change the last space into a '\n' > > Finally it is easy to see that, given the size of cabc_modes, PAGE_SIZE > can not be reached. > So better keep everything simple (and correct). > > Signed-off-by: Christophe JAILLET applied. Thanks! Helge