From: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
To: Colin King <colin.king@canonical.com>
Cc: Thomas Winischhofer <thomas@winischhofer.net>,
linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] video: fbdev: sis: make const array specialtv static, reduces object code size
Date: Thu, 12 Oct 2017 15:30:49 +0000 [thread overview]
Message-ID: <502610747.RoFXOuGC48@amdc3058> (raw)
In-Reply-To: <20170913154137.6886-1-colin.king@canonical.com>
On Wednesday, September 13, 2017 04:41:37 PM Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Don't populate the const array specialtv on the stack, instead make it
> static. Makes the object code smaller by over 1100 bytes:
>
> Before:
> text data bss dec hex filename
> 179899 7504 0 187403 2dc0b drivers/video/fbdev/sis/init301.o
>
> After:
> text data bss dec hex filename
> 178720 7568 0 186288 2d7b0 drivers/video/fbdev/sis/init301.o
>
> (gcc version 7.2.0, x86_64)
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Patch queued for 4.15, thanks.
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
prev parent reply other threads:[~2017-10-12 15:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20170913154142epcas2p41e38ee4285ed856ee6b98edf267da1de@epcas2p4.samsung.com>
2017-09-13 15:41 ` [PATCH] video: fbdev: sis: make const array specialtv static, reduces object code size Colin King
2017-10-12 15:30 ` Bartlomiej Zolnierkiewicz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=502610747.RoFXOuGC48@amdc3058 \
--to=b.zolnierkie@samsung.com \
--cc=colin.king@canonical.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=thomas@winischhofer.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox