From: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
To: Paul Cercueil <paul@crapouillou.net>
Cc: linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org
Subject: Re: [PATCH 2/4] fbcon: prevent possible buffer overflow.
Date: Thu, 23 Aug 2012 20:28:46 +0000 [thread overview]
Message-ID: <5036927E.1080504@gmx.de> (raw)
In-Reply-To: <1343091626-11435-2-git-send-email-paul@crapouillou.net>
On 07/24/2012 01:00 AM, Paul Cercueil wrote:
> Signed-off-by: Paul Cercueil <paul@crapouillou.net>
Applied.
Thanks,
Florian Tobias Schandinat
> ---
> drivers/video/console/fbcon.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/video/console/fbcon.c b/drivers/video/console/fbcon.c
> index a0b1818..3ffab97 100644
> --- a/drivers/video/console/fbcon.c
> +++ b/drivers/video/console/fbcon.c
> @@ -442,7 +442,7 @@ static int __init fb_console_setup(char *this_opt)
>
> while ((options = strsep(&this_opt, ",")) != NULL) {
> if (!strncmp(options, "font:", 5))
> - strcpy(fontname, options + 5);
> + strlcpy(fontname, options + 5, sizeof(fontname));
>
> if (!strncmp(options, "scrollback:", 11)) {
> char *k;
next prev parent reply other threads:[~2012-08-23 20:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-24 1:00 [PATCH 1/4] fbcon: use kstrtouint instead of deprecated function simple_strtoul Paul Cercueil
2012-07-24 1:00 ` [PATCH 2/4] fbcon: prevent possible buffer overflow Paul Cercueil
2012-08-23 20:28 ` Florian Tobias Schandinat [this message]
2012-07-24 1:00 ` [PATCH 3/4] fbcon: continue parsing parameters after an error Paul Cercueil
2012-07-24 1:00 ` [PATCH 4/4] fbcon: optimize parameters parsing loop Paul Cercueil
2012-07-25 14:13 ` paul
2012-07-25 14:14 ` paul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5036927E.1080504@gmx.de \
--to=florianschandinat@gmx.de \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paul@crapouillou.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).