From: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
To: Julia Lawall <Julia.Lawall@lip6.fr>
Cc: kernel-janitors@vger.kernel.org, linux-fbdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] drivers/video/auo_k190x.c: drop kfree of devm_kzalloc's data
Date: Thu, 23 Aug 2012 20:30:02 +0000 [thread overview]
Message-ID: <503692CA.8080608@gmx.de> (raw)
In-Reply-To: <1344081632-4729-1-git-send-email-Julia.Lawall@lip6.fr>
On 08/04/2012 12:00 PM, Julia Lawall wrote:
> From: Julia Lawall <Julia.Lawall@lip6.fr>
>
> Using kfree to free data allocated with devm_kzalloc causes double frees.
>
> The semantic patch that fixes this problem is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @@
> expression x;
> @@
>
> x = devm_kzalloc(...)
> ...
> ?-kfree(x);
> // </smpl>
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Applied.
Thanks,
Florian Tobias Schandinat
>
> ---
> drivers/video/auo_k190x.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/video/auo_k190x.c b/drivers/video/auo_k190x.c
> index 77da6a2..c03ecdd 100644
> --- a/drivers/video/auo_k190x.c
> +++ b/drivers/video/auo_k190x.c
> @@ -987,7 +987,6 @@ err_regfb:
> fb_dealloc_cmap(&info->cmap);
> err_cmap:
> fb_deferred_io_cleanup(info);
> - kfree(info->fbdefio);
> err_defio:
> vfree((void *)info->screen_base);
> err_irq:
> @@ -1022,7 +1021,6 @@ int __devexit auok190x_common_remove(struct platform_device *pdev)
> fb_dealloc_cmap(&info->cmap);
>
> fb_deferred_io_cleanup(info);
> - kfree(info->fbdefio);
>
> vfree((void *)info->screen_base);
>
>
>
prev parent reply other threads:[~2012-08-23 20:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-04 12:00 [PATCH 1/3] drivers/video/auo_k190x.c: drop kfree of devm_kzalloc's data Julia Lawall
2012-08-23 20:30 ` Florian Tobias Schandinat [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=503692CA.8080608@gmx.de \
--to=florianschandinat@gmx.de \
--cc=Julia.Lawall@lip6.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).