From: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
To: Wang YanQing <udknight@gmail.com>,
linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org,
spock@gentoo.org
Subject: Re: [PATCH] video:uvesafb: check the return value of kzalloc
Date: Thu, 23 Aug 2012 20:43:29 +0000 [thread overview]
Message-ID: <503695F1.50207@gmx.de> (raw)
In-Reply-To: <20120813100232.GA16363@udknight>
On 08/13/2012 10:02 AM, Wang YanQing wrote:
>
> Michal maybe forgot it merely, we should add code
> to check the return value of kzalloc to make the
> code more robust.
>
> Signed-off-by: Wang YanQing <udknight@gmail.com>
Applied.
Thanks,
Florian Tobias Schandinat
> ---
> drivers/video/uvesafb.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/video/uvesafb.c b/drivers/video/uvesafb.c
> index b0e2a42..2f8f82d 100644
> --- a/drivers/video/uvesafb.c
> +++ b/drivers/video/uvesafb.c
> @@ -659,6 +659,8 @@ static int __devinit uvesafb_vbe_getedid(struct uvesafb_ktask *task,
> task->t.flags = TF_BUF_RET | TF_BUF_ESDI;
> task->t.buf_len = EDID_LENGTH;
> task->buf = kzalloc(EDID_LENGTH, GFP_KERNEL);
> + if (!task->buf)
> + return -ENOMEM;
>
> err = uvesafb_exec(task);
>
prev parent reply other threads:[~2012-08-23 20:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-13 10:02 [PATCH] video:uvesafb: check the return value of kzalloc Wang YanQing
2012-08-23 20:43 ` Florian Tobias Schandinat [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=503695F1.50207@gmx.de \
--to=florianschandinat@gmx.de \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=spock@gentoo.org \
--cc=udknight@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).