From: Igor Grinberg <grinberg@compulab.co.il>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 6/9] ARM: OMAP1: move omap1_bl pdata out of arch/arm/*
Date: Wed, 29 Aug 2012 21:42:40 +0000 [thread overview]
Message-ID: <503E8CD0.2090608@compulab.co.il> (raw)
In-Reply-To: <1346252664.12380.0.camel@deskari>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 08/29/12 18:04, Tomi Valkeinen wrote:
> On Wed, 2012-08-29 at 02:18 +0300, Igor Grinberg wrote:
>> omap1 backlight platform data resides inside plat/board.h while it
>> should be inside include/linux/...
>> Move the omap1 backlight platform data to
>> include/linux/platform_data/.
>>
>> Cc: Richard Purdie <rpurdie@rpsys.net>
>> Cc: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
>> Cc: linux-fbdev@vger.kernel.org
>> Signed-off-by: Igor Grinberg <grinberg@compulab.co.il>
>> ---
>> arch/arm/mach-omap1/board-osk.c | 1 +
>> arch/arm/mach-omap1/board-palmte.c | 1 +
>> arch/arm/mach-omap1/board-palmtt.c | 1 +
>> arch/arm/mach-omap1/board-palmz71.c | 1 +
>> arch/arm/plat-omap/include/plat/board.h | 7 -------
>> drivers/video/backlight/omap1_bl.c | 2 +-
>> include/linux/platform_data/omap1_bl.h | 11 +++++++++++
>> 7 files changed, 16 insertions(+), 8 deletions(-)
>> create mode 100644 include/linux/platform_data/omap1_bl.h
[...]
>> diff --git a/include/linux/platform_data/omap1_bl.h b/include/linux/platform_data/omap1_bl.h
>> new file mode 100644
>> index 0000000..881a8e9
>> --- /dev/null
>> +++ b/include/linux/platform_data/omap1_bl.h
>> @@ -0,0 +1,11 @@
>> +#ifndef __OMAP1_BL_H__
>> +#define __OMAP1_BL_H__
>> +
>> +#include <linux/device.h>
>
> You could use struct device; here.
Yes I know, but I don't think it is any better.
>
>> +
>> +struct omap_backlight_config {
>> + int default_intensity;
>> + int (*set_power)(struct device *dev, int state);
>> +};
>> +
>> +#endif
>
> Acked-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
Thanks!
- --
Regards,
Igor.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.17 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iQIcBAEBAgAGBQJQPozJAAoJEBDE8YO64EfasmQP/2v38LY4t30rnl3jOvs6vvsa
RPFFQG1lxkFTpMHMkOvb4pW/k00IHxkcv2hRrGmoBWbEJqel7b0LyEFVV+M+uCSo
nCVsnd/Pu7jftCwC2Ggy2PBE16n+9I6UttN4Vsh7a8f2qwtXdOxL01xxyM7cVtn4
YQRhyVrKMiiKhNfKtvQV2V0npsVVksgnKm0K1zNRiZkTuKjZ4sJrliGYaU6B5F32
MHx31U0r1VbxZwOi9m19Ucyuf1CYvVKhlmeMop1fE4+3Dkt1708pMWOpK9iknMQU
m5cA+25a7YolDIluvfXlH+7hDFZixDUd5pFeJA0llaqOv2PSHGT0kYDOTmtRyKvD
D3mq22amwPlqgjXdxJMS5gckF6N3KrBjA3AHW4FpoTQjdCciiql3k+DMaRNM6Dzm
WjCCZBOQHy5dSRn6HzNo2iSP+B8mANh8eoJJAoyS3JJ+ihf4hiV1PEC9jXxWTg1H
M449feGQccXUfYj8pTlXtTXEk8L5x3kBlU9VMMzlA1kQN0VoFOQRhSl+UVdu2ckA
SPotVgiUCUzT9x1xEoIBjrz+kLAk0bYvRv2vUflzzH8lf+/MYz4UxDikSCsifpF1
s/5evCRgSUokm1VxlFEMLiUG0gb8FJR3TylJU4CD5U9dbkel2urKoE1zfc4LyPRT
ycdLeCP+C7ZcsaNApWMS
=kElj
-----END PGP SIGNATURE-----
prev parent reply other threads:[~2012-08-29 21:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1346195937-6383-1-git-send-email-grinberg@compulab.co.il>
2012-08-28 23:18 ` [PATCH 6/9] ARM: OMAP1: move omap1_bl pdata out of arch/arm/* Igor Grinberg
2012-08-29 15:04 ` Tomi Valkeinen
2012-08-29 21:42 ` Igor Grinberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=503E8CD0.2090608@compulab.co.il \
--to=grinberg@compulab.co.il \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).