From: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
To: linux-fbdev@vger.kernel.org
Subject: Re: [PATCH] video: bfin-lq035q1: use module_platform_driver
Date: Sun, 23 Sep 2012 19:27:26 +0000 [thread overview]
Message-ID: <505F629E.2000806@gmx.de> (raw)
On 08/23/2012 09:55 PM, Devendra Naga wrote:
> the driver's module init and exit functions are calling
> platform_driver_register and platform_driver_unregister and doing nothing
> else.
>
> This same as that of the module_platform_driver,
> remove this init and exit functions and use the module_platform_driver instead
>
> Signed-off-by: Devendra Naga <develkernel412222@gmail.com>
Applied.
Thanks,
Florian Tobias Schandinat
> ---
> drivers/video/bfin-lq035q1-fb.c | 12 +-----------
> 1 file changed, 1 insertion(+), 11 deletions(-)
>
> diff --git a/drivers/video/bfin-lq035q1-fb.c b/drivers/video/bfin-lq035q1-fb.c
> index 353c02f..1b21519 100644
> --- a/drivers/video/bfin-lq035q1-fb.c
> +++ b/drivers/video/bfin-lq035q1-fb.c
> @@ -853,17 +853,7 @@ static struct platform_driver bfin_lq035q1_driver = {
> },
> };
>
> -static int __init bfin_lq035q1_driver_init(void)
> -{
> - return platform_driver_register(&bfin_lq035q1_driver);
> -}
> -module_init(bfin_lq035q1_driver_init);
> -
> -static void __exit bfin_lq035q1_driver_cleanup(void)
> -{
> - platform_driver_unregister(&bfin_lq035q1_driver);
> -}
> -module_exit(bfin_lq035q1_driver_cleanup);
> +module_platform_driver(bfin_lq035q1_driver);
>
> MODULE_DESCRIPTION("Blackfin TFT LCD Driver");
> MODULE_LICENSE("GPL");
next reply other threads:[~2012-09-23 19:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-23 19:27 Florian Tobias Schandinat [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-08-23 21:55 [PATCH] video: bfin-lq035q1: use module_platform_driver Devendra Naga
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=505F629E.2000806@gmx.de \
--to=florianschandinat@gmx.de \
--cc=linux-fbdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).