* Re: [PATCH] video: bfin-lq035q1: use module_platform_driver
@ 2012-09-23 19:27 Florian Tobias Schandinat
0 siblings, 0 replies; 2+ messages in thread
From: Florian Tobias Schandinat @ 2012-09-23 19:27 UTC (permalink / raw)
To: linux-fbdev
On 08/23/2012 09:55 PM, Devendra Naga wrote:
> the driver's module init and exit functions are calling
> platform_driver_register and platform_driver_unregister and doing nothing
> else.
>
> This same as that of the module_platform_driver,
> remove this init and exit functions and use the module_platform_driver instead
>
> Signed-off-by: Devendra Naga <develkernel412222@gmail.com>
Applied.
Thanks,
Florian Tobias Schandinat
> ---
> drivers/video/bfin-lq035q1-fb.c | 12 +-----------
> 1 file changed, 1 insertion(+), 11 deletions(-)
>
> diff --git a/drivers/video/bfin-lq035q1-fb.c b/drivers/video/bfin-lq035q1-fb.c
> index 353c02f..1b21519 100644
> --- a/drivers/video/bfin-lq035q1-fb.c
> +++ b/drivers/video/bfin-lq035q1-fb.c
> @@ -853,17 +853,7 @@ static struct platform_driver bfin_lq035q1_driver = {
> },
> };
>
> -static int __init bfin_lq035q1_driver_init(void)
> -{
> - return platform_driver_register(&bfin_lq035q1_driver);
> -}
> -module_init(bfin_lq035q1_driver_init);
> -
> -static void __exit bfin_lq035q1_driver_cleanup(void)
> -{
> - platform_driver_unregister(&bfin_lq035q1_driver);
> -}
> -module_exit(bfin_lq035q1_driver_cleanup);
> +module_platform_driver(bfin_lq035q1_driver);
>
> MODULE_DESCRIPTION("Blackfin TFT LCD Driver");
> MODULE_LICENSE("GPL");
^ permalink raw reply [flat|nested] 2+ messages in thread* [PATCH] video: bfin-lq035q1: use module_platform_driver
@ 2012-08-23 21:55 Devendra Naga
0 siblings, 0 replies; 2+ messages in thread
From: Devendra Naga @ 2012-08-23 21:55 UTC (permalink / raw)
To: linux-fbdev
the driver's module init and exit functions are calling
platform_driver_register and platform_driver_unregister and doing nothing
else.
This same as that of the module_platform_driver,
remove this init and exit functions and use the module_platform_driver instead
Signed-off-by: Devendra Naga <develkernel412222@gmail.com>
---
drivers/video/bfin-lq035q1-fb.c | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/video/bfin-lq035q1-fb.c b/drivers/video/bfin-lq035q1-fb.c
index 353c02f..1b21519 100644
--- a/drivers/video/bfin-lq035q1-fb.c
+++ b/drivers/video/bfin-lq035q1-fb.c
@@ -853,17 +853,7 @@ static struct platform_driver bfin_lq035q1_driver = {
},
};
-static int __init bfin_lq035q1_driver_init(void)
-{
- return platform_driver_register(&bfin_lq035q1_driver);
-}
-module_init(bfin_lq035q1_driver_init);
-
-static void __exit bfin_lq035q1_driver_cleanup(void)
-{
- platform_driver_unregister(&bfin_lq035q1_driver);
-}
-module_exit(bfin_lq035q1_driver_cleanup);
+module_platform_driver(bfin_lq035q1_driver);
MODULE_DESCRIPTION("Blackfin TFT LCD Driver");
MODULE_LICENSE("GPL");
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-09-23 19:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-09-23 19:27 [PATCH] video: bfin-lq035q1: use module_platform_driver Florian Tobias Schandinat
-- strict thread matches above, loose matches on Subject: below --
2012-08-23 21:55 Devendra Naga
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).